Closed cryptomilk closed 5 years ago
Should be working now.
@cryptomilk Andreas, thanks a lot :+1: Builds fine on Windows7. Let's wait for confirmation on Linux. ping @CarVac
If you wonder what do to with those flags e.g. for AddressSanitzer or UndefinedSanitizer, see https://gitlab.com/cmocka/cmocka/pipelines/49122087 for example.
You should add unit tests to make sure the stuff really works and to find bugs.
Also someone should fix the build warnings ;-)
@cryptomilk
You should add unit tests to make sure the stuff really works and to find bugs.
Unit tests would be good for new implementations and improvements to the current implementations. Imho the current initial implementations have got enough tests in RawTherapee the last years to be a good base for unit tests ;-)
@cryptomilk
Trying to build your 'master-cmake' branch I get this (Windows)
$ cmake -G "MSYS Makefiles" -DCMAKE_INSTALL_PREFIX="$MSYSTEM_PREFIX" ..
CMake Error at src/CMakeLists.txt:49 (install):
install Library TARGETS given no DESTINATION!
-- Configuring incomplete, errors occurred!
See also "Z:/H2/librt_crypto/build/CMakeFiles/CMakeOutput.log".
@cryptomilk When I wrote above 'Builds fine on windows', I was on the master branch of your fork by accident. master-cmake does not build on Windows
@cryptomilk @heckflosse it works on fedora, just one issue: the final pkgconfig file must be rtprocess.pc, not rtprocessin.pc
I will fix the pkg-config and check what to do with Windows. CPack is still missing.
A few more updates and fixes ...
@cryptomilk Andreas, I made a fresh clone of your fork and did:
git checkout master-cmake
$ cmake -G "MSYS Makefiles" -DCMAKE_INSTALL_PREFIX="$MSYSTEM_PREFIX" ..
-- The CXX compiler identification is GNU 8.3.0
-- Check for working CXX compiler: C:/msys64/mingw64/bin/g++.exe
-- Check for working CXX compiler: C:/msys64/mingw64/bin/g++.exe -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Could NOT find NSIS (missing: NSIS_MAKE)
-- Found PkgConfig: C:/msys64/mingw64/bin/pkg-config.exe (found version "0.29.2")
-- Checking for module 'glibmm-2.4'
-- Found glibmm-2.4, version 2.58.0
-- Found OpenMP_CXX: -fopenmp (found version "4.5")
-- Found OpenMP: TRUE (found version "4.5") found components: CXX
-- Configuring done
WARNING: Target "rtprocess" requests linking to directory "C:/msys64/mingw64/lib". Targets may link only to libraries. CMake is dropping the item.
-- Generating done
-- Build files have been written to: Z:/H2/librt_crypto/build
@cryptomilk Andreas, on Windows your changes now create a librtprocess.dll
while the former code created a file for static linkage. We should discuss what is intended.
@heckflosse Why do you want a static lib on Windows?
@cryptomilk
Why do you want a static lib on Windows?
I didn't say I want a static lib on Windows. But I would like to hear what maintainers of for example RT windows build think. For my RT builds (which are only for my personal use) it makes no difference.
ping @gaaned92
@heckflosse Could you try building again with MSYS. I haven't had the time to install it in a VM yet. Or I will just use gitlab to cross-compile.
@cryptomilk I will check before midnight
On which day? :-)
Oh, sorry. Completely forgot. Builds fine on Win7/msys
So we're good to go? Now it would be nice to run with AddressSanitzer and UndefinedSanitizer but without any tests that's not possible ...
It starts to bitrot ...
Hi,
this is work in progress. I've started to clean up cmake for librtprocess. This is not ready yet.