Closed heckflosse closed 5 years ago
ping @CarVac and @Benitoite for Linux and Mac builds
@Benitoite I just saw, it's already in the build instructions for Mac...
This is significantly faster for me.
On my 2700X, 21MP files go from 1.25 to 0.25 for LMMSE and 1.06 to 0.16 seconds for Amaze.
Actually, when I turned on the release build for Filmulator's CI, it added a new warning that for some reason didn't get caught on my machine.
/home/travis/build/CarVac/filmulator-gui/librtprocess/src/preprocess/CA_correct.cc:975:57: error: assuming signed overflow does not occur when simplifying conditional to constant [-Werror=strict-overflow]
for (int cc = 0; cc < std::min(border, cc1 - ccmax); cc++) {
~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@CarVac I will have a look at the warning
@CarVac Which compiler was that?
It's gcc 7.
No warning using gcc 9.1 here. Maybe 9.1 sees that ccmax < cc1
is checked two lines above and therefore cc1 - ccmax
can not overflow. Let's ignore it
Let's see if I can get a newer version of gcc in Travis.
I set it to use GCC 9 and it works now.
Following the build instructions, the librtprocess build is very slow on Windows
Example for Amaze demosaic of a 100 MP file: 11.8 seconds
With the cmake command from attached patch the same file is amaze demosaiced in 1.5 seconds
Can someone test if it behaves same on Linux or Mac?