search

CarVac / librtprocess

A project to make RawTherapee's processing algorithms more readily available.
Other
53 stars 24 forks source link

rcd_demosaic(): SSE code for step 3 #58

Closed heckflosse closed 4 years ago

heckflosse commented 4 years ago

@CarVac Is there something wrong with the Travis CI configuration?

heckflosse commented 4 years ago

@butcherg Could you test this pr please?

CarVac commented 4 years ago

It appears the CI has been broken for some time; something about the initial git pull fails.

CarVac commented 4 years ago

In fact, I'm not sure it ever worked.

butcherg commented 4 years ago

I think I can do it some time this weekend...

On Fri, Sep 4, 2020, 5:52 AM CarVac notifications@github.com wrote:

In fact, I'm not sure it ever worked.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/CarVac/librtprocess/pull/58#issuecomment-687096552, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC4RLFOMUAOISH277JSJDDSEDIIZANCNFSM4QX63XHA .

butcherg commented 4 years ago

Static builds no longer available?

heckflosse commented 4 years ago

Static builds no longer available?

???

butcherg commented 4 years ago

Static builds no longer available?

???

I responded via email, but it hasn't shown up...

The switch I used last time, WITH_STATIC_LIB, flags "Manually-specified variables were not used by the project" in the cmake .. run. Went to inspect the log, commit #3b57e7 appears to have removed the switch and the cmake script stuff behind it.

CarVac commented 4 years ago

Hmm, I'm not sure why @cryptomilk did that.

cryptomilk commented 4 years ago

https://cmake.org/cmake/help/v3.18/variable/BUILD_SHARED_LIBS.html

cmake -DBUILD_SHARED_LIBS=OFF ..

butcherg commented 4 years ago

Well, that works... 👍 Thanks, @cryptomilk !

Took me a year to learn the autotools, now I have to figure out cmake. I'm creating a pull request to update the optional cmake directive.

cryptomilk commented 4 years ago

What do you mean exactly?

cmake -L or ccmake are listing it with a description :-)

butcherg commented 4 years ago

-L, didn't know that...

I learned autotools to configure rawproc; I haven't studied cmake yet to do that. When I go to compile other software, I just learn enough to make it work; I have that "sense of the landscape" with autotools to know stuff not specifically documented, but I'm not there yet with cmake.

If we expect others to be able to compile our stuff out-of-the-box, we need to document all they need in our instructions; we can't assume they just know autotools or cmake...

heckflosse commented 4 years ago

@butcherg

If we expect others to be able to compile our stuff out-of-the-box, we need to document all they need in our instructions; we can't assume they just know autotools or cmake..

:+1: