search

CaravanStudios / open-product-recovery

Apache License 2.0
26 stars 20 forks source link

Fixes path error and runs npm install before key creation #57

Closed chrisellis-bcgdv closed 1 year ago

chrisellis-bcgdv commented 1 year ago

Should have opened an issue but it's a quick fix.
When generating the keys as per ReadMe instructions the path to the opr-core folder is incorrect.
A second issue also fixed in this PR (not best practice but it's a small change) is that the user needs to run npm install in the opr-core folder before the key generation will work. This has been added to the .sh file, although it could equally have been added as in instruction in the documentation.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

johndayrichter commented 1 year ago

Thanks so much for this contribution, Chris! We've requested a very minor revision, but we really appreciate the fix!