search

CaravelGames / drod

The official public repository of Deadly Rooms of Death and DROD RPG
http://caravelgames.com
56 stars 17 forks source link

Remove grid style option for puzzle mode #513

Closed Hypexion closed 1 year ago

Hypexion commented 1 year ago

The grid style option doesn't work because it needs graphics, but none were ever supplied. It is also unclear what "grid style" is meant to be, as the comment for in it GridEffect says "size of the grid". Due to this is it is probably best to remove it. (The strings have to remain to preserve the MID ordering)

Thread: https://forum.caravelgames.com/viewtopic.php?TopicID=44932

mrimer commented 1 year ago

@Hypexion , I think skell actually prepared new tile sprites. I didn't include them in the patch I posted on the forum because I had forgotten that new tiles were added for 5.2. I don't want to yank the feature simply because I didn't include the tiles. If I'm missing something in regards to this change, however, please let me know.

Hypexion commented 1 year ago

@Hypexion , I think skell actually prepared new tile sprites. I didn't include them in the patch I posted on the forum because I had forgotten that new tiles were added for 5.2. I don't want to yank the feature simply because I didn't include the tiles. If I'm missing something in regards to this change, however, please let me know.

If there are actually new graphics that can be included then this PR shouldn't be required.

Hypexion commented 1 year ago

Since there are graphics, closing.