search

Caraxi / ItemSearchPlugin

Dalamud Plugin for searching for items
Other
14 stars 9 forks source link

Use OnCheckMessageHandled to suppress try-on messages #13

Closed PrincessRTFM closed 2 years ago

PrincessRTFM commented 3 years ago

Currently, the plugin is using an OnChatMessage handler to suppress the "You try on the [...]" messages, but this means that any other plugins using OnChatMessage that have their handlers registered before this plugin's one will still see the unhandled message.

As an example, XIVChat's server uses that handler to send chat messages to connected clients, meaning that clients may (depending on plugin load order) still see those messages. If the suppression check were moved to instead be done with OnCheckMessageHandled, then marking them as handled would properly hide them from other plugins as well, not to mention ensure that such messages are seen before content-transforming plugins.

Caraxi commented 2 years ago

Fixed in 73b4d28d8d03c5d2f7a73e02ce4f0fb990302c69