Fix potential crash issue with CraftingRecipeFinder

Caraxi / ItemSearchPlugin

Dalamud Plugin for searching for items

Other

14 stars 10 forks source link

Fix potential crash issue with CraftingRecipeFinder #7

Closed ff14wed closed 4 years ago

ff14wed commented 4 years ago

These changes make the method to search for recipes far safer since we want to remove ourselves from writing memory directly and saving offsets for object fields.

ff14wed commented 4 years ago

Actually, once I have time later in a few hours I may make further changes to make this method more reliable.

ff14wed commented 4 years ago

Alright, changes are done.

Repro for crashing with previous implementation:

Start game
Log in
Immediately try to use recipe search

Even with the PluginLog preceding the search call, this method does not crash with the above repro steps.