Caraxi / SimpleTweaksPlugin

GNU Affero General Public License v3.0
161 stars 140 forks source link

[Suggestion] Screenshot Improvements #543

Closed shelltar closed 1 year ago

shelltar commented 1 year ago

I would love to have a screenshot option that allows custom shaders in this tweak.

Caraxi commented 1 year ago

ReShade just works

shelltar commented 1 year ago

Oh, it takes screenshots without ReShade for me.

Caraxi commented 1 year ago

are you using dxgi for reshade?

shelltar commented 1 year ago

Yeah.

Caraxi commented 1 year ago

no idea then, I've never had it not work with reshade for me and I can't imagine theres any way to force it to work if it doesn't

I'll investigate hooking into ReShade's screenshot function but it might not be doable

shelltar commented 1 year ago

Do you think RTGI has anything to do with it not working for me?

Caraxi commented 1 year ago

its a possibility I suppose

shelltar commented 1 year ago

Here is what ReShade logs when I take the screenshot. It may help you. I use this preset.

06:45:18:441 [16968] | INFO  | Redirecting IDXGISwapChain::ResizeBuffers(this = 000001DC8E72CE90, BufferCount = 2, Width = 10240, Height = 4320, NewFormat = 28, SwapChainFlags = 0x2) ...
06:45:18:443 [16968] | INFO  | Destroyed runtime environment on runtime 000001DC8EAA6F80 ("D:\Games\Steam\steamapps\common\FINAL FANTASY XIV Online\game\ReShade.ini").
06:45:18:445 [16968] | INFO  | Recreated runtime environment on runtime 000001DC8EAA6F80 ("D:\Games\Steam\steamapps\common\FINAL FANTASY XIV Online\game\ReShade.ini").
06:45:18:573 [21588] | INFO  | Successfully compiled "D:\Games\Steam\steamapps\common\FINAL FANTASY XIV Online\game\reshade-shaders\Shaders\PD80\PD80_04_Contrast_Brightness_Saturation.fx" in 0.027 s.
06:45:18:574 [21340] | INFO  | Successfully compiled "D:\Games\Steam\steamapps\common\FINAL FANTASY XIV Online\game\reshade-shaders\Shaders\KeepUI.fx" in 0.017 s.
06:45:18:576 [06368] | INFO  | Successfully compiled "D:\Games\Steam\steamapps\common\FINAL FANTASY XIV Online\game\reshade-shaders\Shaders\MXAO 4.0.2 EX.fx" in 0.082 s.
06:45:18:576 [05964] | INFO  | Successfully compiled "D:\Games\Steam\steamapps\common\FINAL FANTASY XIV Online\game\reshade-shaders\Shaders\Tonemap.fx" in 0.022 s.
06:45:18:602 [18324] | INFO  | Successfully compiled "D:\Games\Steam\steamapps\common\FINAL FANTASY XIV Online\game\reshade-shaders\Shaders\brussell\EyeAdaption.fx" in 0.047 s.
06:45:18:603 [18784] | INFO  | Successfully compiled "D:\Games\Steam\steamapps\common\FINAL FANTASY XIV Online\game\reshade-shaders\Shaders\ColorMatrix.fx" in 0.019 s.
06:45:18:631 [21588] | INFO  | Successfully compiled "D:\Games\Steam\steamapps\common\FINAL FANTASY XIV Online\game\reshade-shaders\Shaders\PD80\PD80_04_Selective_Color_v2.fx" in 0.042 s.
06:45:18:641 [21340] | INFO  | Successfully compiled "D:\Games\Steam\steamapps\common\FINAL FANTASY XIV Online\game\reshade-shaders\Shaders\LumaSharpen.fx" in 0.014 s.
06:45:18:646 [02380] | INFO  | Successfully compiled "D:\Games\Steam\steamapps\common\FINAL FANTASY XIV Online\game\reshade-shaders\Shaders\FilmicPass.fx" in 0.027 s.
06:45:18:655 [21340] | INFO  | Successfully compiled "D:\Games\Steam\steamapps\common\FINAL FANTASY XIV Online\game\reshade-shaders\Shaders\LUT.fx" in 0.014 s.
06:45:18:711 [02380] | INFO  | Successfully compiled "D:\Games\Steam\steamapps\common\FINAL FANTASY XIV Online\game\reshade-shaders\Shaders\Glamayre_Fast_Effects.fx" in 0.038 s.
06:45:20:220 [16968] | INFO  | Redirecting IDXGISwapChain::SetFullscreenState(this = 000001DC8E72CE90, Fullscreen = FALSE, pTarget = 0000000000000000) ...
06:45:20:220 [16968] | INFO  | Redirecting IDXGISwapChain::ResizeBuffers(this = 000001DC8E72CE90, BufferCount = 2, Width = 2560, Height = 1080, NewFormat = 28, SwapChainFlags = 0x2) ...
06:45:20:222 [16968] | INFO  | Destroyed runtime environment on runtime 000001DC8EAA6F80 ("D:\Games\Steam\steamapps\common\FINAL FANTASY XIV Online\game\ReShade.ini").
06:45:20:224 [16968] | INFO  | Recreated runtime environment on runtime 000001DC8EAA6F80 ("D:\Games\Steam\steamapps\common\FINAL FANTASY XIV Online\game\ReShade.ini").
06:45:20:427 [22696] | INFO  | Successfully compiled "D:\Games\Steam\steamapps\common\FINAL FANTASY XIV Online\game\reshade-shaders\Shaders\MXAO 4.0.2 EX.fx" in 0.059 s.
06:45:20:429 [09616] | INFO  | Successfully compiled "D:\Games\Steam\steamapps\common\FINAL FANTASY XIV Online\game\reshade-shaders\Shaders\KeepUI.fx" in 0.006 s.
06:45:20:438 [21408] | INFO  | Successfully compiled "D:\Games\Steam\steamapps\common\FINAL FANTASY XIV Online\game\reshade-shaders\Shaders\Tonemap.fx" in 0.009 s.
06:45:20:447 [02336] | INFO  | Successfully compiled "D:\Games\Steam\steamapps\common\FINAL FANTASY XIV Online\game\reshade-shaders\Shaders\brussell\EyeAdaption.fx" in 0.01 s.
06:45:20:456 [08476] | INFO  | Successfully compiled "D:\Games\Steam\steamapps\common\FINAL FANTASY XIV Online\game\reshade-shaders\Shaders\PD80\PD80_04_Contrast_Brightness_Saturation.fx" in 0.032 s.
06:45:20:486 [20672] | INFO  | Successfully compiled "D:\Games\Steam\steamapps\common\FINAL FANTASY XIV Online\game\reshade-shaders\Shaders\ColorMatrix.fx" in 0.007 s.
06:45:20:496 [08476] | INFO  | Successfully compiled "D:\Games\Steam\steamapps\common\FINAL FANTASY XIV Online\game\reshade-shaders\Shaders\PD80\PD80_04_Selective_Color_v2.fx" in 0.024 s.
06:45:20:508 [13704] | INFO  | Successfully compiled "D:\Games\Steam\steamapps\common\FINAL FANTASY XIV Online\game\reshade-shaders\Shaders\FilmicPass.fx" in 0.007 s.
06:45:20:512 [09616] | INFO  | Successfully compiled "D:\Games\Steam\steamapps\common\FINAL FANTASY XIV Online\game\reshade-shaders\Shaders\LumaSharpen.fx" in 0.02 s.
06:45:20:530 [09616] | INFO  | Successfully compiled "D:\Games\Steam\steamapps\common\FINAL FANTASY XIV Online\game\reshade-shaders\Shaders\LUT.fx" in 0.008 s.
06:45:20:594 [13704] | INFO  | Successfully compiled "D:\Games\Steam\steamapps\common\FINAL FANTASY XIV Online\game\reshade-shaders\Shaders\Glamayre_Fast_Effects.fx" in 0.034 s.
Caraxi commented 1 year ago

I added an option to use GShade for the actual screenshot cdfb9ba84b26c436e9dfaec78ae9f8522a44a3bb

shelltar commented 1 year ago

Thank you so much! I'll test it once servers are up.