Caraxi / SimpleTweaksPlugin

GNU Affero General Public License v3.0
156 stars 141 forks source link

[Disable Title Screen Movie] Overwrite conditional jump instead of resetting idle time #723

Closed carvelli closed 1 week ago

carvelli commented 6 months ago

The idle time is currently only reset in FrameworkUpdate which is running after the actual check for how long you've been idle. If you somehow manage to hang the FFXIV process for >1 minute, that means the title screen movie will play regardless of whether the tweak is currently enabled.

The code changes the conditional jump for idleTime <= 60000 to an unconditional jump, so movies never play automatically.

This is the current IdleTime while making this PR (playing a movie would reset it to 0): image

Caraxi commented 6 months ago

idk... this is how I used to do it and changed because it was prone to breaking