Carberra / Carberretta

A Discord bot designed for the Carberra Discord server.
https://discord.carberra.xyz
BSD 3-Clause "New" or "Revised" License
17 stars 14 forks source link

CronJob & dev updates #163

Closed aoi-yuito closed 1 year ago

aoi-yuito commented 1 year ago

Sorry man! I accidentally deleted the previous PR to delete a single message sent by mistake. My bad! I am new to these stuffs. Well anyways, as you have told me earlier to set a CronTrigger to refresh the caches and also to update the requirements-dev.txt. All is done but I am not sure about the requirements-dev.txt Did I do something wrong while updating the dev file?

aoi-yuito commented 1 year ago

Alright I understood what you meant by to update the requirements-dev.txt.

parafoxia commented 1 year ago

For the requirements (and more generally the checks as a whole), if you do pip install nox then run nox, you'll run the checks. Running nox -s dependencies will tell you which requirements need to be updated in the files, and to what versions.

I would reset the requirements file to what was there before, then run the nox check, and make the changes it recommends.

I'll be able to check the rest of it when I'm on my computer. Though those nox checks should inform you how to fix your formatting and import errors.

aoi-yuito commented 1 year ago

No worries! I fixed the dependency error but I am clueless about the import errors.

parafoxia commented 1 year ago

Looks like you fixed them lmao. One of the times it fails is if they're not formatted correctly, so fixing the formatting can sometimes fix the imports too, which is what's happened here. Changes you've made in the last commit look good.

aoi-yuito commented 1 year ago

Yeah Lol, thank you very much for telling me the secret of life!