1.20 port - Githubissues

Carbon-Config-Project / CarbonConfig

Apache License 2.0

3 stars 2 forks source link

Closed Trinsdar closed 6 months ago

Trinsdar commented 11 months ago

errors left to fix: this.getBlitOffset in CarbonIconButton and CarbonButton RenderSystem.disableTexture in ElementList renderBg in CarbonButton

Speiger commented 11 months ago

Thank you for the start. Please await until the actual patch for 1.19.2 is done. I have started today the rewrites/changes. Next patch Branch

Speiger commented 11 months ago

@Trinsdar

getBlitOffset can be removed. It was never used.
disableTexture is equal to setting the ShaderTexture id to 0. (so simply set the shader texture for bank 0)
renderbg can be also removed use renderbutton instead.

Speiger commented 10 months ago

@Trinsdar do you think you can finish the 1.20.2 port next week?

Speiger commented 9 months ago

o/ To give a bit of transparency. I will accept this pullrequest next year and complete the release. And also port it to 1.20.2 and 1.20.4 too.

But for this year i consumed all my coding time ^^" I hope you don't mind.