search

Carbon-Farm-Network / app-carbon-farm-network

GNU Affero General Public License v3.0
1 stars 0 forks source link

After add to plan, the event icon not there #101

Closed fosterlynn closed 6 months ago

fosterlynn commented 6 months ago

I added two commitments to the Pick Up input column. Both before saving, and after it comes back from the save, they do not have the icon to add an economic event. I don't know if it shows up after picking Edit on the Plan list, I'm still timing out on that. If it shows then, we can make this low priority or next phase. If not, we'll need to fix it for phase 2.

(I also don't know if that is on purpose because the commitment hasn't saved yet.)

Screenshot from 2024-03-01 14-11-41

LeosPrograms commented 6 months ago

Yes, the commitment needs to save before you can add an event to it. The only way to fix this would be to save commitments immediately or wait to save economic events until after saving the whole plan.

On Fri, Mar 1, 2024, 9:42 PM Lynn Foster @.***> wrote:

I added two commitments to the Pick Up input column. Both before saving, and after it comes back from the save, they do not have the icon to add an economic event. I don't know if it shows up after picking Edit on the Plan list, I'm still timing out on that. If it shows then, we can make this low priority or next phase. If not, we'll need to fix it for phase 2.

(I also don't know if that is on purpose because the commitment hasn't saved yet.)

Screenshot.from.2024-03-01.14-11-41.png (view on web) https://github.com/Carbon-Farm-Network/app-carbon-farm-network/assets/3776081/f1e0922c-20ef-403c-b721-0fc78ba3de89

— Reply to this email directly, view it on GitHub https://github.com/Carbon-Farm-Network/app-carbon-farm-network/issues/101, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEO3RDOUYMRN5FQDDY6PS7TYWDR3VAVCNFSM6AAAAABECL4BNGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGE3DIMJUGI2TOOI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

fosterlynn commented 6 months ago

Yes, the commitment needs to save before you can add an event to it. The only way to fix this would be to save commitments immediately or wait to save economic events until after saving the whole plan.

Got it. As long as when going back into a saved plan using Edit shows the event icon, than seems good enough, unless it becomes a problem for users. I can also agree that we shouldn't reload the plan after a save, it takes too long. I can't see if it works from Edit, but I'll assume it does, and close this. Anyhow, it is all part of the bigger question of the long saves.