Carbon-Farm-Network / app-carbon-farm-network

GNU Affero General Public License v3.0
2 stars 0 forks source link

Map search works only for agent name #24

Open fosterlynn opened 1 year ago

fosterlynn commented 1 year ago

Or working with strange rules, see below.

Screenshot from 2023-07-20 09-03-54

pospi commented 1 year ago

fixed in 369458c

fosterlynn commented 1 year ago

Reopening. Still not working for me. It seems like it should have, but I'm not positive that this commit made it into the release that came out yesterday afternoon? Screenshot from 2023-08-02 12-11-17

fosterlynn commented 1 year ago

Testing again with new release, here are some results. It is doing something, but unclear to me what. Below the search screen prints are the popup prints so you can see the data. If you need to see more data, the seed is acfn-8-11. Screenshot from 2023-08-12 12-29-50 Screenshot from 2023-08-12 12-30-04 Screenshot from 2023-08-12 12-30-55 Screenshot from 2023-08-12 12-31-16 Screenshot from 2023-08-12 12-31-30 Screenshot from 2023-08-12 12-31-50 Screenshot from 2023-08-12 12-45-43 Screenshot from 2023-08-12 12-45-48 Screenshot from 2023-08-12 12-45-52

fosterlynn commented 1 year ago

Possible additional clues, at least to try to re-create:

When I first went into the map on my new installation, after entering a couple agents, and typed "scour" into the search, it correctly brought up only the agent with "scour" in it's information. From then on, it always brought up both agents no matter what I entered. Even going out and back into the app itself now it always brings up both agents.

I think also after I had the one successful search, I entered facets and an offer for one agent.

pospi commented 1 year ago

Should be fixed in latest commits, was an issue with recursively matching against agents involved deeper in the Proposal data attached to Agents for the purposes of display on the map.

fosterlynn commented 1 year ago

Sorry, re-opening again, not working for me, although it is different. I'll ask Laura/Evan to test this too.

Screenshot from 2023-09-19 07-02-50

Screenshot from 2023-09-19 06-57-15

But.... (probably from the "valley" part, with more of "alpaca" it disappeared) Screenshot from 2023-09-19 06-57-01

If you want to test, feel free to join seed acfn-09-19, but let me know so I can bring it up first.

fosterlynn commented 1 year ago

Much better! Works great for agent names. Doesn't find resource spec names, facet values, etc. But we can prioritize those if wanted, let's check first. I'll leave it open until I check.