search

Carbon-Farm-Network / app-carbon-farm-network

GNU Affero General Public License v3.0
1 stars 0 forks source link

Quantities showing on the plan #96

Closed fosterlynn closed 5 months ago

fosterlynn commented 6 months ago

At the beginning, the commitment quantities are displayed. Adding an event changes it to the event quantity, at least when the event finishes the commitment.

Right now we are not supporting multiple events (but we will need to do that), and that will just be supported by updating the event. But, what should show if the commitment is not finished but there is an event? I think the commitment quantity would be best there, of those choices.

But is a better solution to keep the commitment quantity, and add another line for the event(s) quantity? Or add it to the commitment quantity line somehow, something like "pickup 20 pound" > "pickup 20 pound (18)". But that doesn't support other changes, like provider, which might be unlikely for CFN, but not for every group.

Needs discussion with the CFN.

fosterlynn commented 6 months ago

Discussion with the users: Leave it how it is now, with event quantity replacing commitment quantity, they will see during use if they feel like they need more.

Right now I can't tell if we are allowing update of the one event, or allowing multiple events on one commitment. Either is fine (eventually we'll want multiple events). If we are creating multiple events now, add the quantities together for what displays on the commitment.

LeosPrograms commented 6 months ago

Screenshot from 2024-03-01 09-49-27 Screenshot from 2024-03-01 10-15-18 How is this?

fosterlynn commented 6 months ago

This is interesting! Looks good to me.

Does it work on commitments too? Or just on the offer list?

LeosPrograms commented 6 months ago

Just the offer list

fosterlynn commented 6 months ago

The line on the offers is looking good! One small change: If there are none available (i.e. available is N/A, basically not limited, like the services), which suppressed the available line, let's also suppress the n of n requested line. Screenshot from 2024-03-01 13-31-35

fosterlynn commented 6 months ago

Tested the multiple events adding up the quantities on the commitment, looks good!

fosterlynn commented 6 months ago

In the screen shot above, Gray Alpaca Dirty from Farm 1 shows 34 on the pickup commitment, but does not show "34 of 44" on the offer. But when I added a pickup or changed a pickup commitment, it did then show up on the offer correctly. So just the first time displayed it is not there.

LeosPrograms commented 6 months ago

I changed it to show from the beginning. However, this may be inaccurate, as the original offer is not referenced in the agreement.

Also, removed "of x" from requested line, as the availability is listed above and would be redundant.

fosterlynn commented 5 months ago

Good for now!