Carbonateb / obsidian-encore-theme

The Encore theme aims to freshen up the UI of Obsidian.md with modern design, loosely based off Material 3.
MIT License
71 stars 5 forks source link

[BUG] Table cells/rows grow in height when clicked on #26

Closed CyclopeanCompact closed 6 months ago

CyclopeanCompact commented 6 months ago

Describe the Bug Whenever I click on a table cell while using Encore, the row abruptly expands to four or five times the cell's original height; simultaneously, this seems to be treated by Obsidian as an attempt to position the caret at the very end of the afflicted line, so it means it is impossible to select a line of text in a table in one held click since it moves the caret to the wrong position.

I thought it'd be fixed with the patch that fixed the last issue with the new tables, but no such luck.

Relevant Screenshots If applicable, add screenshots to help explain your problem.

image image

To Reproduce

  1. Create a table of any size or shape.
  2. Click on any row.

In which mode does the bug occur?

Which editor are you using?

Which version of Obsidian are you using?

Checklist

Carbonateb commented 6 months ago

hmm I wasn't able to reproduce the issue on my end

image

it could be a weird edge case between some of your plugins and Encore, maybe try opening a new vault and gradually adding back plugins until the issue occurs?

CyclopeanCompact commented 6 months ago

So after seeing a fresh drive with Encore and nothing else installed worked, I did some further A/B testing, systemically stripping out every part of my .obsidian folder. I eventually determined that Style Settings appeared to somehow be the root of the problem, but after installing it on a new vault, it appeared to work fine. The actual problem is Encore's Fancy View Headers. Enabling this setting under Style Settings is what causes the awkward table issues. I had it enabled on my original personal vault, but it isn't enabled by default, so the new vault didn't experience the problem until I toggled it on.

Carbonateb commented 6 months ago

Ah, great job finding the cause of the issue! I was able to reproduce it on my end, and have issued a fix :)

Thanks for the report ❤️

Yeah I disabled fancy headers by default due to the number of issues it causes with plugins and such, I'd prefer new users to have a more polished albeit less fancy experience by default.