search

Carbonateb / obsidian-encore-theme

The Encore theme aims to freshen up the UI of Obsidian.md with modern design, loosely based off Material 3.
MIT License
71 stars 5 forks source link

#4 - update: set --file-line-width to 80 percent and fix #5

Closed jtprogru closed 1 year ago

jtprogru commented 1 year ago

Default --file-line-width is equal 700 px. The width of 700px leaves too little space for the content, and the 80% I offer is a more suitable option.

If you don't mind, then I would like to make a fork and modify it for myself, distributing it as a separate Obsidian design theme. Please let me know about your attitude to this offer. I'm want to extract only One Dark (Atom) theme decoration – it's so beautiful for me :)

jtprogru commented 1 year ago

In last commit I fix the #4

Carbonateb commented 1 year ago

Hey jtprogru, sorry for the late reply. I tested out your changes, I noticed some small issues where the width of some lines are different to others. Like, callouts and line breaks seem to extend further. I did some digging and found that the 80% width is being applied twice to some lines.

As a possible alternative, have you tried turning off the readable line length setting (under Editor > Display), it could be what you're looking for. It's not exactly the same as it removes all spacing.

I realize that V2 is a pretty big departure from the old version, so if you prefer V1 I'm happy for you to distribute it as another theme. All you'd need to do is submit your fork to Obsidian, probably call it something like Encore • Minimal as it's a more lightweight version of the main theme.

Thank you for sharing your changes!

jtprogru commented 1 year ago

Thanks for answer, @Maldonacho! I will wait for the release of V2 and compare it with what I would like to see. Setting the readable line length is not quite suitable, because it expands the area to the maximum possible value, and I would like to see small margins when working on a laptop.

If V2 cannot provide the necessary experience, then I will be very happy to make a fork with the preservation of the original authorship.