Card-Forge / forge

An unofficial rules engine for the world's greatest card game.
https://card-forge.github.io/forge/
GNU General Public License v3.0
934 stars 544 forks source link

Adventure Mode - Game Save/World Wide set or edition filter... not just a config file. #1066

Closed austeregrim closed 2 years ago

austeregrim commented 2 years ago

Is your feature request related to a problem? Please describe. I'm always frustrated when I find cards or sets that really don't belong in normal gameplay in adventure mode.

Describe the solution you'd like The ability to filter sets upon game world creation, instead of in a config file game wide.

Describe alternatives you've considered Staring at the monitor until the pixels updated in a fashion I willed them to using only my mind... (it doesn't work.)

Additional context I give you a heart in the discord if you do this.

For clarity; I'd like to see either a white list for sets at game/world creation, or the ability to create and manage planes in game (with whitelisting sets/editions), or the ability to edit and manage planes via configs (with ability to whitelist sets/editions). NOT a universal filter for the entire game, and not a file that will be overwritten with an update which is how the current config file method is.

TrueFuFLeaderG commented 2 years ago

It can be configured in config.json made a wiki entry on how to Configure-Planes What cards are you talking about? If it is editions like unset it would be easy to exclude those, but Commander cards for example are more difficult, I don't think that they have a property to filter them out.

austeregrim commented 2 years ago

Yeah, but the request is for specifically to have the settings editable in the start of the game and set per save. Or since you've got the config file as it is, should be able to add individual planes, or custom. I'd be happy to add core set planes to a config publicly if it can be used to populate the plane selection at game start.

I'm only asking as a feature request because I asked from the beginning, and editing a config for every device I have is not really what I want to do, especially when it gets overwritten with updates.

Maybe add a "planes" config file, that can have a title line, a map file, and set's limited. Maybe I want to play Core 2020 today in one save, and 4ED in another save.

austeregrim commented 2 years ago

Especially with the trashcan editions coming out, I don't want to see fortnite cards ever...

austeregrim commented 2 years ago

There I updated my request to be clearer, I think it's time this gets added.

TrueFuFLeaderG commented 2 years ago

I see, so a edition selection based on the Character, this contradicts a little bit the idea of planes selection. Would work fine in Shandalar but not on other plains but it could be an "Shandalar exclusive" feature.

maybe i find some time to add it.

For those unwanted cards, I have no problem to exclude non canon cards in Shandalar.

austeregrim commented 2 years ago

It can be plane based. But I'd like to have those planes available in game, and the configs available so the planes cane be made and selected. That way I can start making planes either for myself or start contributing and make additional planes available. It's one of the major hurdles for me getting into adventure mode, there's just too many cards/sets/editions etc. where it would be nice to be able to flesh out a meta, in general, and then for each plane.

Since there wouldn't be any maps created for the plane yet, it can use the same default map you've got.

austeregrim commented 2 years ago

Right, I see I'm a dumb. I didn't realize the folder was the plane, not the entire game environment. Then I withdraw this request.

Jorilx commented 9 months ago

I'm sorry, where should I place my custom config.json? I've tried $HOME/.forge/adventure/userplanes/MyPlane/config.json but Forge ignores it... Am I missing something? (My settings.json contains "plane": "<user>MyPlane")