search

Card-Forge / forge

An unofficial rules engine for the world's greatest card game.
https://card-forge.github.io/forge/
GNU General Public License v3.0
1.03k stars 571 forks source link

Syr Konrad, the Grim (ELD) not triggering when he also dies #3181

Open Samthere opened 1 year ago

Samthere commented 1 year ago

My Konrad died at the same time as a bunch of other creatures (tokens and nontokens) but didn't trigger his damage.

Current snapshot, Windows. image

tool4ever commented 1 year ago

One thing I don't like about him is how his templating combines those events into a single trigger so it's only 1/3 LTB ability 😕

github-actions[bot] commented 1 year ago

This issue has not been updated in a while and has now been marked as stale. Stale messages will be auto closed.

dracontes commented 3 months ago

At least as far as the original report goes, Syr Konrad, the Grim is working as intended, as it states in its trigger condition "Whenever another creature dies, [...]".

Edit: Though, on a closer look, should the non-dies trigger conditions be as strict, using Other in the argument? On the one hand it doesn't affect gameplay (from my understanding), on the other it's apparent nonfunctional code that could be trimmed.

Samthere commented 3 months ago

At least as far as the original report goes, Syr Konrad, the Grim is working as intended, as it states in its trigger condition "Whenever another creature dies, [...]".

The issue wasn't that he doesn't trigger himself, it's that he didn't trigger for a bunch of other creatures dying, which he should see when he dies at the same time as them.

dracontes commented 3 months ago

it's that he didn't trigger for a bunch of other creatures dying, which he should see when he dies at the same time as them.

Oh, my mistake then. While I'm at it, I checked on desktop-1.6.64-SNAPSHOT-08-05 and it's working fine in that regard now.

image