Card-Forge / forge

An unofficial rules engine for the world's greatest card game.
https://card-forge.github.io/forge/
GNU General Public License v3.0
975 stars 561 forks source link

"Blink" saga not working properly; triggering first effect as Chapter II #3957

Closed Glorax closed 9 months ago

Glorax commented 1 year ago

Describe the bug The Blink saga triggers its first effect as Chapter II, shuffling a creature into the library and creating a clue token under control of the same player. The effect triggers three times in a row in total. The effect that creates the Alien Angel token only occurs once, as Chapter IV.

To Reproduce Steps to reproduce the behavior:

  1. Play "Blink".
  2. Allow chapters I through IV to trigger.

Expected behavior The effects should alternate. I and III shuffle a creature into the library and create a clue. II and IV create an Alien Angel token.

Desktop (please complete the following information):

Additional context Perhaps the way sagas are currently coded is not equipped to handle repeated Chapters that are "out of order". I checked the script for the card, and it seems like it should be working properly, yet it does not.

Hanmac commented 12 months ago

@tool4ever can you check this? it should only have been a visual issue?

tool4ever commented 12 months ago

yea I didn't expect that either but the report is correct I should probably wait for your refactor for a fix?

Hanmac commented 12 months ago

i need to touch saga chapters anyway for new ReadAhead

github-actions[bot] commented 11 months ago

This issue has not been updated in a while and has now been marked as stale. Stale messages will be auto closed.