Open Glorax opened 11 months ago
the problem with such token images, like Embalm or Eternalize too, is that they could be misleading
seemingly create Tokens what look like that they are vanilla (with no abilities) but they still have Embalm or Eternalize, even if it doesn't make sense for the token
Also Naktamun the Plane gives all creatures Embalm
There's also the fact that said Embalm and Eternalize tokens appear to be the wrong colour, and also can be easily confused with the non-embalmed versions of themselves...
I also wonder if there should be a setting to have all token copies of non-token cards use copy token artwork, to more easily distinguish them from the originals.
There's an existing setting called "Clones Use Original Card Art", but I'm not convinced that it actually does anything; I've turned it on and turned it off and it appears to make no difference. (At first I thought it was supposed to ensure shapeshifters like Clone used their own card art after being put into play, but I currently have it turned on, and they still use the image of the copied card.)
There's also the fact that said Embalm and Eternalize tokens appear to be the wrong colour, and also can be easily confused with the non-embalmed versions of themselves...
I also wonder if there should be a setting to have all token copies of non-token cards use copy token artwork, to more easily distinguish them from the originals.
There's an existing setting called "Clones Use Original Card Art", but I'm not convinced that it actually does anything; I've turned it on and turned it off and it appears to make no difference. (At first I thought it was supposed to ensure shapeshifters like Clone used their own card art after being put into play, but I currently have it turned on, and they still use the image of the copied card.)
If you want live update/representation of card effects on the card state (like colors for the border/frame, text etc and don't mind memory usage), try to use Crop in Card Art format for Desktop GUI or use Art in Border Mask Option for Mobile GUI
I don't have most of the images downloaded in order to save space, including the cropped card art. And I only have full art images of the cards I'm using in my commander decks and cubes. Instead, I have the setting turned on that tells me what the colour is if it's been changed. But I don't believe that setting is turned on by default.
I am curious about why they "Clones Use Original Card Art" setting seemingly doesn't do anything. I'd love to know what it's actually supposed to do. If it's not working as intended, I can write up a separate bug report for that.
Clones Use Original Card Art
it seems it is setting the default art for clone on earlier version but it was remove on CloneRewrite update last 4/24/2019, @Hanmac forgot to remove the option... look here: https://github.com/Card-Forge/forge/commit/ba8a38c2f4a79c3f216991570a8ab1a2594c297d
I guess I will remove that option since it's not supposed to be there as it will not do anything...
This issue has not been updated in a while and has now been marked as stale. Stale messages will be auto closed.
With Bloomburrow adding Offspring, this is all the more reason to implement this change. The tokens from Offspring are also not using their unique token images.
I explicit added a Offspring image key for this
So it should work, or is it in-progress? The token-images.txt doesn't even have file paths written out for them.
Is your feature request related to a problem? Please describe. Some cards that create tokens that are copies of existing cards actually have specialized token images for the copies, like Warhammer (and now Fallout) decks' Squad cards, or Osgood, Operation double. They do not, instead using the card art of the original card—even though several of these tokens (the Squad cards at the least) have data in the "token-images" file. (Which indicates that the files are actually being downloaded, but unused.)
Describe the solution you'd like The Squad cards and Osgood should use the specialized token images that were created for them instead of the images of the original card. Some kind of exception might have to be coded in for the Squad ability and Osgood.
Describe alternatives you've considered I can't think of an actual alternative to this that doesn't involve leaving it as-is. This would be particularly disappointing in Osgood's case, since the token artwork actually depicts a different (yet identical) character and the other half of the regular card's artwork.