Card-Forge / forge

An unofficial rules engine for the world's greatest card game.
GNU General Public License v3.0
921 stars 541 forks source link

AI activates ability of Elvish Piper at it's turn #4280

Open MorihiroS opened 8 months ago

MorihiroS commented 8 months ago

Describe the bug AI activates ability of Elvish Piper at it's turn. It loses the effect of surprise.

To Reproduce Steps to reproduce the behavior:

  1. AI casts Elvish Piper
  2. In next AI's turn AI activates ability of Elvish Piper

Expected behavior

  1. AI should activate ability of Elvish Piper as late as possible. Ideally at the end of the opponent's turn
  2. AI should activate ability of Elvish Piper in response to casting player's Cursed Totem, Phyrexian Revoker, Pithing Needle and other cards with "Activated abilities can't be activated"
  3. AI should activate ability of Elvish Piper in response to an attack by a player's creatures before blockers are assigned
  4. AI should activate ability of Elvish Piper in response of player's spells that targets Elvish Piper
  5. AI should activate ability of Elvish Piper in it's turn before combat if it has creatures with haste or creatures like Iona, Shield of Emeria
  6. AI should activate ability of Elvish Piper in it's turn if player has Aether Vial with 2 counters and/or has only two lands and one of these lands can produce blue mana (i.e. a player cannot cast Tishana's Tidebinder this turn, but can next turn)

Additional context Similar for Monster Manual and Quicksilver Amulet

Desktop OS: Windows 10 Java Version: 1.8.0_202-b08 Forge Version: 1.6.59-SNAPSHOT-12.02

Screenshots

piper

github-actions[bot] commented 7 months ago

This issue has not been updated in a while and has now been marked as stale. Stale messages will be auto closed.

MorihiroS commented 7 months ago

@Hanmac, need AI label, keep label and assign Agetian, pls

MorihiroS commented 6 months ago

Upd: AI should activate ability of Elvish Piper in it's turn if player has Aether Vial with 2 counters and/or has only two lands and one of these lands can produce blue mana (i.e. a player cannot cast Tishana's Tidebinder this turn, but can next turn)