Card-Forge / forge

An unofficial rules engine for the world's greatest card game.
https://card-forge.github.io/forge/
GNU General Public License v3.0
1.01k stars 571 forks source link

AI doesn't cast Batwing Brume #4784

Closed MorihiroS closed 4 months ago

MorihiroS commented 8 months ago

Describe the bug AI doesn't cast Batwing Brume when an opponent's creatures are attacked

To Reproduce Steps to reproduce the behavior:

  1. AI has 2+ untapped lands
  2. AI has Batwing Brume
  3. Player attacks with 3+ creatures
  4. AI doesn't cast Batwing Brume

Expected behavior AI should cast Batwing Brume for white and black mana (as possible) when an opponent's 3+ creatures are attacked or if this damage will be lethal. There should be multiple payment options for AI: for BW, for 1W (without B), and for 1B (without W).

Additional context I think all cards that have mana payment in the text have similar problems (https://scryfall.com/search?as=grid&order=name&q=%28oracle%3Awas+oracle%3Aspent+oracle%3Ato+oracle%3Acast+oracle%3Athis%29+%28game%3Apaper%29).

Desktop OS: Windows 10 Java Version: 1.8.0_202-b08 Forge Version: 1.6.60-SNAPSHOT-02.29

Screenshots

Brume1

tool4ever commented 8 months ago

I don't understand these reports. This card (like many others) is clearly marked as AI:RemoveDeck:All You should be warned when you force that on it in a deck

MorihiroS commented 8 months ago

@tool4ever, and I don't understand your outrage. Since the card is marked as AI:RemoveDeck:All, it can't be coded?

tool4ever commented 8 months ago

I'm not really outraged... If you don't appreciate me telling you you're wasting your time since us developers (well really anybody) can easily search for the affected cards then that's fine by me. Continue doing this for your pet cards by all means 🤦‍♂️

MorihiroS commented 8 months ago

@tool4ever, I'm not marking cards that should in principle be difficult for AI (Prismatic Ending, Rakdos Charm, Shadow of Doubt, and so on). I'm marking the ones that intuitively should be understandable by AI, but somehow aren't. For example, AI makes great use of Springleaf Drum, but for some reason it only puts it on the battlefield with Urza's Saga. I get the feeling they've just been forgotten about.

They're not my "pet cards". Most of these cards are played in tier or popular decks, and often AI plays these decks poorly because of weird moments like this, which I don't think are hard to fix.

And I try to do what I can for the project. Now, for example, AI can fully play Aether Vial and Karn, the Great Creator, although there were some basic flaws before my requests. Now AI plays great with human decks and merfolk decks.

Continue doing this for your pet cards by all means

🤦‍♂️

Oh, that's so constructive and inviting to communicate (no).

But according to your reply, I'm really wasting my time here volunteering and making requests that even the description of the card at the stack stopped being corrected....

tool4ever commented 8 months ago

In theory everything can be coded but unique stuff might not be worth the effort (what is "easy" for the AI depends on a few factors).

But I don't think you're understanding my point: image Why are you ignoring this warning?

image I know you're trying to help out but we don't need your reports for 2500+ of these cards...

While it is possible that some tagged cards have become playable, that would require additional/different research.

MorihiroS commented 8 months ago

Why are you ignoring this warning?

I'm not ignoring the warning, I'm considering it. But I can see that AI easily using Springleaf Drum, and the whole problem is that it doesn't cast it from hand.

Batwing Brume doesn't feel like a broken card either. Can't it be possible to make the card have 3 payment modes, or at least one, so that AI uses it like Fog?

I know you're trying to help out but we don't need your reports for 2500+ of these cards...

@tool4ever, even if I close all ~13 requests with cards from the warnings (which is no guarantee at all that they will be noticed later), there are a ~73 requests left, ranging from the simplest #4372 to #4152 and #4266, all with different problems.

tool4ever commented 8 months ago
MorihiroS commented 8 months ago

@tool4ever, thank you for the detailed explanation! But what should I do with these requests? Should I close them as unrealizable? And the other ones too (like #4391)?

And what should I do with those ~73 requests that are not included in the warnings?

tool4ever commented 8 months ago
Hanmac commented 8 months ago

imo they should all be fixed in the future

but they have lower priority

github-actions[bot] commented 7 months ago

This issue has not been updated in a while and has now been marked as stale. Stale messages will be auto closed.

MorihiroS commented 4 months ago

Card is marked as AI:RemoveDeck:All