SacrificeEffect: refactor Cumulative upkeep & Echo

Card-Forge / forge

An unofficial rules engine for the world's greatest card game.

https://card-forge.github.io/forge/

GNU General Public License v3.0

952 stars 551 forks source link

Open tool4ever opened 4 months ago

tool4ever commented 4 months ago

If possible clean them up to use normal UnlessCost$.

This would help with some mana restrictions checks for costs like from Volcano Hellion.

Hanmac commented 4 months ago

About Cumulative Upkeep:

imo the logic behind Cumulative Upkeep has way too many hops to jump through to use just UnlessCost for this
especially because they are trigger if the Upkeep Cost isn't paid

About Echo:

Thick-Skinned Goblin: You may pay {0} rather than pay the echo cost for permanents you control. we need to update that with a Static (AlternativeCost doesn't work forEffect)
Shah of Naar Isle also has an Echo Paid Trigger

github-actions[bot] commented 3 months ago

This issue has not been updated in a while and has now been marked as stale. Stale messages will be auto closed.