Card-Forge / forge

An unofficial rules engine for the world's greatest card game.
GNU General Public License v3.0
885 stars 534 forks source link

Creating Named Token by Card Name #5416

Open Hanmac opened 1 month ago

Hanmac commented 1 month ago

111.11. If an effect instructs a player to create a token by name, doesn’t define any other characteristics for that token, and the name is not one of the types in the list of predefined tokens above, that player uses the card with that name in the Oracle card reference to determine the characteristics of that token. Example: Disa the Restless has the ability “Whenever one or more creatures you control deal combat damage to a player, create a Tarmogoyf token.” As that ability resolves, its controller creates a token with the same characteristics as the card named Tarmogoyf, as determined by the Oracle card reference.

For now, we could keep our Token Scripts, but that is the difference between:

Also, Tarmagoyf token should not be affected by Card Text Changes. So they should be marked with LockTokenScript

tehdiplomat commented 1 month ago

We're chatting in discord. There probably isn't really anything to do here except utilize existing script syntax;

CopyPermanent | DefinedName$

Hanmac commented 1 month ago

We still might need to update CopyPermanentEffect that we don't need ValidSupportedCopy when using DefinedName

that code piece is a leftover from Momir Vig, Simic Visionary Avatar that isn't used anymore

the only different thing is that it probably would use the wrong image (from the tarmagoyf card instead of the tarmagoyf token)

Edit: because DefinedName is unused, we might change it to our liking