Card-Forge / forge

An unofficial rules engine for the world's greatest card game.
GNU General Public License v3.0
927 stars 541 forks source link

Crash involving experimental snapshot and a triggered ability of a token copy of a clone with explicitly set copiable values #5596

Open dracontes opened 1 month ago

dracontes commented 1 month ago

Describe the bug / To Reproduce On Constructed. Deck generation set to single color Random Color Decks; not that it seems important since this happened while pulling cards from the Catalog with the Dev Tools to test them. Undo Restore wasn't toggled on.

Expected behavior Plainly, that the game wouldn't crash from doing this, even if I suspect I may be relying too much on the Dev Tools to test card scripts.

Files

Desktop:

tool4ever commented 1 month ago

From the log it shows the experimental snapshot feature was involved. That's something for @tehdiplomat to debug.

dracontes commented 1 month ago

From the log it shows the experimental snapshot feature was involved. That's something for @tehdiplomat to debug.

Okay, after I managed to get Forge to load from source on Eclipse, seeing as I apparently needed JDK 22 and JDK (1.)8 for that the forge-java8.exe file stopped working as a means to start Forge.* I kept my cool long enough to find that forge.exe now works. I believe I had the experimental snapshot toggled on. Of course, when I went to check for the above bug report it wasn't toggled on. I checked again to see if I could toggle it on and off, and I can't get the setting to stick being ON on restart. I tested another setting I had OFF and that one sticks ON on restart (it's Enable Sounds). I'll see if the sequence above works on Forge while started via Eclipse.

ETA: Checked \AppData\Roaming\Forge\preferences\forge.preferences and experimental restore was toggled to true in the file. Edited it to false and let's see how it goes.

* Crash logs for starting up from forge-java8.exe appended for convenience. java8crash_1 is what I get first and then java8crash_2 repeats itself. They admittedly seem similar to what I got on Eclipse while I hadn't things set up well for Forge to run from source.

2024-07-14-00_java8crash_1.txt 2024-07-14-00_java8crash_2.txt

dracontes commented 1 month ago

let's see how it goes.

And the sequence I described on the initial bug report now works without a problem on forge.exe. Still can't get the experimental snapshot toggled ON while settings like Enable Music can be toggled on and off freely. No, it doesn't change the setting on file while failing to display the check mark.

github-actions[bot] commented 3 weeks ago

This issue has not been updated in a while and has now been marked as stale. Stale messages will be auto closed.

Hanmac commented 3 weeks ago

opens java.util means you need this params: https://github.com/Card-Forge/forge/blob/6847247519a5f14ecd0e5e1b2737e857dc978d16/forge-gui-desktop/src/main/config/forge.sh#L46