Card-Forge / forge

An unofficial rules engine for the world's greatest card game.
https://card-forge.github.io/forge/
GNU General Public License v3.0
990 stars 565 forks source link

AI counts MDFC lands only as lands #5603

Open MorihiroS opened 3 months ago

MorihiroS commented 3 months ago

Describe the bug AI counts modal double-faced cards with lands only as lands. So, AI doesn't activate ability of Goblin Charbelcher and/or doesn't cast Recross the Paths at deck with modal double-faced cards with lands.

To Reproduce Steps to reproduce the behavior:

  1. AI has deck with only MDFC lands
  2. AI casts Goblin Charbelcher
  3. AI has 3 untapped lands
  4. AI doesn't activate ability of Goblin Charbelcher

and

  1. AI has deck with only MDFC lands
  2. AI has 3 untapped lands
  3. AI has Recross the Paths in hand
  4. AI doesn't cast Recross the Paths

BUT

  1. AI has deck with usual lands
  2. AI has 3 untapped lands
  3. AI has Recross the Paths in hand
  4. AI casts Recross the Paths

Expected behavior AI shouldn't count modal double-faced cards with lands only as lands.

Desktop

Screenshots

charbelcher Recross recross

MorihiroS commented 2 months ago

@Hanmac, need AI label, keep label and assign someone

Hanmac commented 2 months ago

what kind of MDFC Lands are we talking about? the normal ones with Land/Land on both sides? or the ones where only the Backside is a Land?

different problems. [[Goblin Charbelcher]] does need extra logic because AI doesn't want to find Lands for full potential. But because MDFC aren't lands in Deck, they shouldn't count

Recross the Paths doesn't work with MDFC. because it would just order the library

MDFC Lands should only count as lands when they are PLAYED

MorihiroS commented 2 months ago

what kind of MDFC Lands are we talking about? the normal ones with Land/Land on both sides?

@Hanmac, I tested in a landless belcher deck that contains the ones where only the Backside is a Land

Hanmac commented 2 months ago

you should post the deck you mean

because i think the lands you mean aren't Lands in the Library

what i think for Goblin Belcher is that AI thinks the deck doesn't contain any Lands (and maybe there is some special AI logic for Belcher missing)

MorihiroS commented 2 months ago

@Hanmac, done!

Combo.zip