Card-Forge / forge

An unofficial rules engine for the world's greatest card game.
https://card-forge.github.io/forge/
GNU General Public License v3.0
1.02k stars 571 forks source link

Spells/abilities are incorrectly displayed on the stack #5634

Open MorihiroS opened 4 months ago

MorihiroS commented 4 months ago

Describe the bug Some spells/abilities have incorrect text when they're displayed in the stack:

To Reproduce Steps to reproduce the behavior:

  1. AI/Player casts Assassin's Trophy/All is Dust/Recross thе Paths/Surgical Extraction/activates The One Ring/etc.
  2. See wrong figure

Expected behavior

Additional context Similar with #4318

Desktop

Screenshots

trophy all is dust recr1 surg Onedraw1 Onedraw2 Nahiri crypt1 crypt2 wildfire tear sleight wrong

MorihiroS commented 3 months ago

Also problem with activated ability of The One Ring

MorihiroS commented 3 months ago

Also problem with activated ability of Nahiri, the Harbinger, with Crypt Incursion and with Wildfire

MorihiroS commented 3 months ago

@Hanmac, need StackDesc label, GUI label, keep label and assign someone, please

Hanmac commented 3 months ago

some of them can be fixed with using ChangeTypeDesc

MorihiroS commented 2 months ago

Add Tear Asunder, Sleight of Hand and Witherbloom Command

MorihiroS commented 1 month ago

@dracontes, is this issue a part of what you are trying to fix in #6218, #6219 and #6220 ?

dracontes commented 1 month ago

@dracontes, is this issue a part of what you are trying to fix in #6218, #6219 and #6220 ?

I don't think so. The only thing I'm attempting to address in this ball park on those PRs is how additional costs for permanent spells are displayed in different places in-game. From your issue list, I do believe I attempted to tackle Assassin's Trophy, only to realize that, at the time, it was a bit beyond me.