Card-Forge / forge

An unofficial rules engine for the world's greatest card game.
https://card-forge.github.io/forge/
GNU General Public License v3.0
989 stars 565 forks source link

Possible bug with Omo's everything counter and creature lands #5636

Open TheLastNarwhal opened 3 months ago

TheLastNarwhal commented 3 months ago

Describe the bug I have Omo, Queen of Vesuva + Ashaya, Soul of the Wild on the field and it doesn't appear that the everything counters are granting my Forest land creatures every land type. In the screenshot I have 5 lands that are gates and two land creatures with everything counters - so they should also be gates - but when I tap Baldur's Gate for its ability that gives mana equal to other gates you control I only get 5 mana instead of the expected 7.

Is this correct?

Expected behavior I would assume that the everything counters would give all land types to creature lands, 'cause Omo's static ability just says "lands" not "noncreature lands."

Screenshots Screenshot_20240717_100137

Desktop (please complete the following information):

Edit: It also appears that Omo is still granting the creatures all creature types even when they're lands due to Ashaya. This doesn't seem correct since that ability only works on nonland creatures. Is this a dependancy issue? Or am I completely wrong about all of this because it involves dependencies and layers and I don't fully understand those?

Hanmac commented 3 months ago

Looks like a Dependency Problem

Forge currently can't see that there should be a Dependency on Omo, Queen of Vesuva to Ashaya, Soul of the Wild

That's why it is trying to apply the ability of Omo, Queen of Vesuva first, which results in the Problem you see