Card-Forge / forge

An unofficial rules engine for the world's greatest card game.
https://card-forge.github.io/forge/
GNU General Public License v3.0
933 stars 543 forks source link

Inconsistent plurals for costs in in-game card text display #5916

Open dracontes opened 1 month ago

dracontes commented 1 month ago

Describe the bug Automatic text generation for display of costs in-game has trouble with some complex costs. A few examples:

I could go on but you get the gist.

To Reproduce

  1. Start a regular game and go quickly through the initial checks.
  2. Then use Dev Mode to put the relevant cards in hand. Hovering the mouse cursor over them should reveal any issues with the automatic text on the Card Detail pane.

Expected behavior That the plurals would be more consistent. At the very least this should mean that baked-in descriptions when provided shouldn't be wholly ignored or entrained into the automatic generation process that's used on simpler arguments for costs, which admittedly has humorous outcomes. On the other hand, the automatic generation process could be improved. I do reckon that the Card case for Abandon Hope and the Stitchwing should be straightforward.

Desktop (please complete the following information):

kevlahnota commented 1 month ago

Maybe we can update Lang.java using inflector library... https://github.com/atteo/evo-inflector