Describe the bug
Automatic text generation for display of costs in-game has trouble with some complex costs. A few examples:
tapping more than one untapped permanent for an activated ability (Adaptive Gemguard)
→ removing the baked-in description as it worked int the case of Ulamog the Defiler ( https://github.com/Card-Forge/forge/pull/5915 ), only results in revealing the argument for the cost (Artifact;Creature).
discarding more than one card as a mandatory additional cost (Abandon Hope)
→ changing the baked-in description doesn't do anything to the displayed text, though comparing with Aether Tide, I take it the additional cost should be structured differently.
discarding more than one card for an activated ability (Advanced Stitchwing)
→ As for Abandon Hope, changing the baked-in description (or adding it) doesn't do anything to the displayed text.
sacrificing more than one permanent for an activated ability (Akul the Unrepentant)
I could go on but you get the gist.
To Reproduce
Start a regular game and go quickly through the initial checks.
Then use Dev Mode to put the relevant cards in hand. Hovering the mouse cursor over them should reveal any issues with the automatic text on the Card Detail pane.
Expected behavior
That the plurals would be more consistent. At the very least this should mean that baked-in descriptions when provided shouldn't be wholly ignored or entrained into the automatic generation process that's used on simpler arguments for costs, which admittedly has humorous outcomes. On the other hand, the automatic generation process could be improved. I do reckon that the Card case for Abandon Hope and the Stitchwing should be straightforward.
Desktop (please complete the following information):
OS: Windows 11
Version: 1.6.64-SNAPSHOT-08-05
Additional afterthoughts
The current solution for both Adaptive Gemguard and Akul would be to drop the last 's' on the baked-in description since that's what's throwing off the automatic generation. The issue to me is that this would look weird to people not in the know while reading scripts and, frankly, would have those in the know cleaning up after them one way or another.
Admittedly CostDesc$ is the stopgap here, though I'm not sure where that should apply vs a description baked into the cost parameter.
It's true the solution on point 1 then affects the prompt players get while activating the ability in an undesirable way
Describe the bug Automatic text generation for display of costs in-game has trouble with some complex costs. A few examples:
Artifact;Creature
).I could go on but you get the gist.
To Reproduce
Expected behavior That the plurals would be more consistent. At the very least this should mean that baked-in descriptions when provided shouldn't be wholly ignored or entrained into the automatic generation process that's used on simpler arguments for costs, which admittedly has humorous outcomes. On the other hand, the automatic generation process could be improved. I do reckon that the
Card
case for Abandon Hope and the Stitchwing should be straightforward.Desktop (please complete the following information):
Version:
1.6.64-SNAPSHOT-08-05
Additional afterthoughts
CostDesc$
is the stopgap here, though I'm not sure where that should apply vs a description baked into the cost parameter.