Open Jetz72 opened 1 month ago
@Jetz72 should be fixed by this: https://github.com/Card-Forge/forge/pull/5921 merged yesterday
No. I didn't fix the merged/melded part yet
One important thing to note, this is only relevant for the experimental undo restore feature. So shouldn't really be blocking.
Ah, that'd explain why this hasn't come up more. Could have sworn I turned that feature off but I guess not.
Tangential note, it might be worthwhile to add an issue tag for the snapshot/restore system.
This issue has not been updated in a while and has now been marked as stale. Stale messages will be auto closed.
Describe the bug
Game.findById
relies onforEachCardInGame
to locate cards. This checks all the ordinary game zones, but does not check theZoneType.Merged
, which contains components of merged permanents beyond the original one in the battlefield. It also does not checkPlayerZoneBattlefield.meldedCards
(and in fact, nothing does), which is where secondary components of melded permanents are kept.To Reproduce
Or:
In either case, the engine crashes in GameSnapshot.assignGameState with this stack trace:
Version
e93b130a3631c5f4642330a65f31efa9f3a0e1ca
. Few days old, but should still be there unless I overlooked a relevant commit in the last couple days.Remarks Might make sense to have the secondary melded cards share the Merged zone as well. Also realized that
forEachCardInGame
is also missing the extra deck zones.