search

Card-Forge / forge

An unofficial rules engine for the world's greatest card game.
https://card-forge.github.io/forge/
GNU General Public License v3.0
1.02k stars 571 forks source link

Miracle&Madness: use ManaCost instead of CardManaCost #6606

Closed Hanmac closed 2 days ago

Hanmac commented 3 days ago

This fixes the Problem with Miracle and Madness not using the right value for Spells to cast.

I'm not 100% happy with PlayReduceCost yet, because i think this should reduce the cost BEFORE you choose values for X or how 2-hybrid costs are chosen.

tool4ever commented 2 days ago

it's actually starting to look like they want the cost reduction to work on X shards too 🤔

So maybe consistency with external foretell is something to consider later

tool4ever commented 2 days ago

But the stupid thing is some judges say it still needs to be treated a bit differently: 464637515_582731397426704_445586349640712613_n

Hanmac commented 2 days ago

But the stupid thing is some judges say it still needs to be treated a bit differently: 464637515_582731397426704_445586349640712613_n

I don't think that is the case, I need to ask Dunk again if he answers

Hanmac commented 2 days ago

I found this: https://github.com/Estellarium/Aminatous-Enchantment-Discount/blob/main/README.md

From reading, that should include Kicker Cost?

tool4ever commented 2 days ago

A random Git repository just for this? I trust it 0% :p

The bigger question for me is if Instant/Sorcery on e.g. Virtue of Strength should really be allowed...

But I think we can just merge this after my findings above get eliminated, then we'd still have 3 cases fixed good 👍