CardanoSolutions / ogmios

❇️ A WebSocket JSON/RPC bridge for Cardano
https://ogmios.dev
Mozilla Public License 2.0
304 stars 90 forks source link

QueryResponse[ledgerTip] type. Should this be Tip instead of Point? #11

Closed rhyslbw closed 3 years ago

rhyslbw commented 3 years ago
{ "oneOf":
          [ { "$ref": "#/definitions/Point" }
          , { "$ref": "#/definitions/EraMismatch" }
          , { "$ref": "#/definitions/QueryUnavailableInCurrentEra" }
          ]
        }

https://github.com/KtorZ/cardano-ogmios/blob/master/docs/static/ogmios.wsp.json#L577

KtorZ commented 3 years ago

I agree, but it's beyond me here :no_mouth:

https://github.com/input-output-hk/ouroboros-network/blob/master/ouroboros-consensus-shelley/src/Ouroboros/Consensus/Shelley/Ledger/Query.hs#L83

This :point_up: is how the ouroboros-network defines it, as a Point :/