Reflection responses keyed as mirror in wsp.json - Githubissues

CardanoSolutions / ogmios

❇️ A WebSocket JSON/RPC bridge for Cardano

https://ogmios.dev

Mozilla Public License 2.0

304 stars 90 forks source link

Reflection responses keyed as mirror in wsp.json #19

Closed rhyslbw closed 3 years ago

rhyslbw commented 3 years ago

What Git revision are you using?

0790ce4e98e6250f68f3c6903b1ad0ae9ca91d65

What operating system are you using, and which version?

[x] Linux / Ubuntu

Describe what the problem is?

There's a couple of reflection objects keyed as mirror:

AcquireResponse

https://github.com/KtorZ/cardano-ogmios/blob/0790ce4e98e6250f68f3c6903b1ad0ae9ca91d65/docs/static/ogmios.wsp.json#L376

ReleaseResponse

https://github.com/KtorZ/cardano-ogmios/blob/0790ce4e98e6250f68f3c6903b1ad0ae9ca91d65/docs/static/ogmios.wsp.json#L438

What should be the expected behavior?

Should be reflection

KtorZ commented 3 years ago

Nice catch. The test generator now make sure to also generate responses with non-null reflection. Fixed in 86e6f1457f3ace6cab310931de33816e1db9c9c7