CardboardPowered / cardboard

The Bukkit/Spigot/Paper API implementation for Fabric
https://cardboardpowered.org
GNU General Public License v3.0
986 stars 57 forks source link

Support for BKCommonLib and TrainCarts #208

Open vico93 opened 3 years ago

vico93 commented 3 years ago

Hi!

This afternoon i made a test server only with Fabric (0.11.3 for 1.16.5), Cardboard 159 (for 1.16.5) and the build 1037 of @bergerkiller 's BKCommonLib for test (since i use TrainCarts in my private servers).

Seems like the plugin didn't load properly (see log), it gives said errors and inactivate itself after.

In the past, in other custom/hybrid Bukkit/Spigot servers, bergerkiller always patched his side (BKCL) to support them, but for Cardboard i wasn't able to say to him if the project have all resources he need to patch. So that's why i'm creating a ticket here.

So, is theoretically possible to add support for this plugin?

bergerkiller commented 3 years ago

I'll just say the answer is no, simply because the main reason I need to write such support, is because of the at-runtime code generation that occurs inside the library. Of course anything is possible, but in this instance they'd need to write code specifically for BKCommonLib to work, which is weird.

But I can ask the inverse: does Cardboard support use of net.minecraft.server code, normally? So far I only added support for Forge-based servers, I don't know if this is any different with Fabric (or in this case: a mod for Fabric adding the Bukkit API)

If this mod only adds the Bukkit API, with a Bukkit API Fabric-specific implementation that isn't based on/forked CraftBukkit, then it currently isn't possible to add such support.

vico93 commented 2 years ago

Just for curiosity, i tried running a "blank" cardboard server, with the following mods:

And i got this "crash" here: Gist.

I hope Isaiah can look with this (what can be done on cardboard side, of course) when he has time...

vico93 commented 2 years ago

Day 2 trying to run a fresh instance of Cardboard (with nothing but CB itself, Fabric API and iCommon).

I don't know if something changed in Cardboard side, but here is the latest.log of the iteration. Still a lot of bugs.

Hope Isaiah will add the support needed for @bergerkiller to allow BKCL to load on top of CB, TrainCarts is the only mod remaining that keeps me back in 1.12. I really don't want to stay with Forge - and Forge/Spigot hybrids, worldgen became super slow post-1.13 and Fabric have the most interesting mods currently.

vico93 commented 1 year ago

Well, coming back after almost a year. Was some progress made on Cardboard side to allow @bergerkiller to add support for it on BKCommonLib? FYI here is the log from my latest attempt to run Cardboard (on 1.18.2, latest build) with BKCL and TrainCarts to see what would happen.

I'm aware my insistence can appear to be annoying for most, but the concept of Berger's TrainCarts are yet to be implemented natively by Fabric/Quilt (and even Forge, after Railcraft got discontinued), differently from other kind of plugins like for admin control, permissions and server tools. I think the ability to run TC in Cardboard can be a mark for the project for really paving the way to original concepts on Spigot/Paper to appear on "standard" modded Minecraft.

vico93 commented 1 year ago

Sorry the 🆙 , but is there any news about this issue on Cardboard side?

Last time i attempted to load BKCL with Cardboard (1.18.2) it give me again an endless crash.