search

Cardiac-MR-Group-Lund / segment-open

Segment Source Distribution
Other
72 stars 31 forks source link

Usage of the function nansum requires additional toolboxes #12

Open fyrdahl opened 2 years ago

fyrdahl commented 2 years ago

Steps to reproduce

The files calcfunctions.m, reportflow.m, perfusion.m, dyssyncrony.m and reportbullseye.m uses the function nansum which requires the user to install either the "Financial Toolbox" or the "Statistics and Machine Learning Toolbox".

Using this function is no longer recommended by MathWorks, as the same behavior can be achieved by the built-in sum function with the option 'omitnan'. Granted, the deprecation notice was issued with R2020b, and the recommended version for segment-open is R2019a, I still wanted to raise this issue.

Moreover, it would be great if the list of toolboxes indicated which ones are mandatory and which are optional, as not everyone has an academic license with access to all toolboxes. Can some of the mandatory toolboxes be made optional using error handling? The Parallel Computing Toolbox seems to be mandatory for setting the toolbar icon for LV-segmentation and optional for everything else.

Details

Version/commit: v3.2 R8836 / 6214d7a95151ce52b972b022120d0333fcd82d0c Link to data set used: N/A

johannestoger commented 2 years ago

Thanks for letting us know! I have forwarded this to the upstream company, let's see what they say.

PS We would be very happy if you could submit a patch of what we need to change!

johannestoger commented 2 years ago

Hi again @fyrdahl, the upstream company is looking into it. Will let you know what they find out.

johannestoger commented 2 years ago

Hi again, @fyrdahl - the upstream company devs let me know that they are strained by sick leaves etc right now... but in ~2 weeks they will be able to look in to it likely.

johannestoger commented 1 year ago

Hi again. I got an updated list from the developers after a long delay. In the next update there will be a reduced number of toolboxes needed.