search

CardiacModelling / ap-nimbus-client

Other
2 stars 2 forks source link

PKPD graph TimePoint (h) axis in log format #101

Closed flawmop closed 1 year ago

flawmop commented 1 year ago

As mentioned in https://cardiac-modelling.slack.com/archives/DKUA91H29/p1683140113202649, to the inexperienced eye (i.e. mine) it doesn't look right to have the display of PKPD - APD90 vs. TimePoint results showing the TimePoint (h) on a log scale.

MauriceHendrix commented 1 year ago

that link doesn't work for me

flawmop commented 1 year ago

Hmm! Slack's apparently not-so-handy "copy link" facility!

https://files.slack.com/files-tmb/T1973F84X-F0563TKEP7D-c31317630f/pkpd_480.png (from our Slack conversation 5th May @ 2:54pm)

MauriceHendrix commented 1 year ago

what simulation parameters is this for? I just tried to mimic what the old portal did maybe best to see with @mirams. The scale would be set somewhere in teh JS I'm sure.

flawmop commented 1 year ago

It's when you supply some PKPD input to the simulation.

mirams commented 1 year ago

Yeah, time shouldn't ever be on a log axis.

MauriceHendrix commented 1 year ago

@flawmop have you got the tsv file you used for that example? & what model & other settings?

MauriceHendrix commented 1 year ago

image Is that waht you were expecting? If soo see #104

flawmop commented 1 year ago

That certainly looks better. It looks like it's not possible to toggle individual concentration plots unfortunately (so in that plot you've shown it's not clear where concentrations 1 and 2 are hiding, but we can add that as a enhancement issue). Which model/blocks was that?

MauriceHendrix commented 1 year ago

O'Hara-Rudy CiPA with all the default settings and your PKPD file

flawmop commented 1 year ago

Resolved by https://github.com/CardiacModelling/ap-nimbus-client/pull/104