search

CardiacModelling / ap-nimbus-client

Other
2 stars 2 forks source link

Initial proposed fix #124

Closed flawmop closed 1 year ago

flawmop commented 1 year ago

Fix for https://github.com/CardiacModelling/ap-nimbus-client/issues/123

Would be reassuring to have @MauriceHendrix give us the nod that these Django-related changes are unlikely to have any unintended consequences!

codecov[bot] commented 1 year ago

Codecov Report

Merging #124 (0c9666e) into master (4de716e) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #124   +/-   ##
=======================================
  Coverage   99.60%   99.60%           
=======================================
  Files          30       30           
  Lines        1503     1503           
  Branches      244      244           
=======================================
  Hits         1497     1497           
  Misses          6        6

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

flawmop commented 1 year ago

Thanks for the feedback @MauriceHendrix, I've reverted my initial fix and created a new migration, which I assume is what you're suggesting. The experience has prompted me to add a couple of simplified instructions to the RtD at https://ap-nimbus.readthedocs.io/en/latest/developer/container/index.html#django-migrations