CardiacModelling / ap-nimbus-client

Other
2 stars 2 forks source link

LDAP authentication option #132

Open martinjrobins opened 2 months ago

martinjrobins commented 2 months ago

@mirams, I would like to add an LDAP authentication option for login. This would:

I would propose to use the django-auth-ldap library to do this (I've used this before for https://github.com/pkpdapp-team/pkpdapp), which would be added as a dependency

Motivation: To enable a deployment of ap-nimbus within the Roche authentiation system

mirams commented 2 months ago

This sounds good to me, would welcome a pull request (plus any sensible tests you can think of for it). @kwabenantim is mainly looking after this at the moment, any thoughts @kwabenantim?

kwabenantim commented 2 months ago

That sounds like a useful feature to me as well.

martinjrobins commented 2 months ago

Great :) I’ll get started on this and submit a pr when finished

martinjrobins commented 2 months ago

update on this, I have an implementation which I think should work, but am blocked at the moment as I can't access the servers I need to test it. Once my access is restored I'll test this and then make a PR