CardiacModelling / ap-nimbus-client

Other
2 stars 2 forks source link

fixed typos and reinstated running as user in contaier #95

Closed MauriceHendrix closed 1 year ago

MauriceHendrix commented 1 year ago

this should fix those typos and reinstate running as user, mentioned in PR 63

codecov[bot] commented 1 year ago

Codecov Report

Merging #95 (832220b) into master (58d8ef6) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #95   +/-   ##
=======================================
  Coverage   99.60%   99.60%           
=======================================
  Files          30       30           
  Lines        1502     1502           
  Branches      244      244           
=======================================
  Hits         1496     1496           
  Misses          6        6           
Impacted Files Coverage Δ
client/config/production_settings.py 100.00% <100.00%> (ø)
client/core/templatetags/ap_nimbus.py 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

flawmop commented 1 year ago

Can you add the PIVACY_NOTICE rename to these changes and then I'll try them out locally and merge if ok?

flawmop commented 1 year ago

Rats! Hadn't noticed that the Error-with-timeout branch (for https://github.com/CardiacModelling/ap-nimbus-client/pull/94) changes hadn't been merged with the typos_and_user branch (for https://github.com/CardiacModelling/ap-nimbus-client/pull/95), so I'll reapply the Error-with-timeout changes.