CardiacModelling / ap-nimbus

Cardiac modelling in containers
Other
1 stars 1 forks source link

More documentation adjustments. #63

Closed flawmop closed 1 year ago

flawmop commented 1 year ago

Random server.js removed from repo root.

flawmop commented 1 year ago

Sorry Maurice, just found a few more changes to add to the above. Will include them and remove the "draft" status and let you know.

MauriceHendrix commented 1 year ago

So far the changes make sense to me, just let me know when you're done.

flawmop commented 1 year ago

@MauriceHendrix , I've made a few changes since you approved last week :

  1. Merged in your recent changes to the docs.
  2. Included your newly added docker env var properties (can you change https://github.com/CardiacModelling/ap-nimbus-client/blob/master/docker/env#L47 to PRIVACY_NOTICE please?)
  3. Adjusted the original instructions to reflect the current situation regarding building/running the containers (I'll get in touch separately with some of the problems I've had running the containers).
MauriceHendrix commented 1 year ago

@MauriceHendrix , I've made a few changes since you approved last week :

  1. Merged in your recent changes to the docs.
  2. Included your newly added docker env var properties (can you change https://github.com/CardiacModelling/ap-nimbus-client/blob/master/docker/env#L47 to PRIVACY_NOTICE please?)
  3. Adjusted the original instructions to reflect the current situation regarding building/running the containers (I'll get in touch separately with some of the problems I've had running the containers).

aah darn silly typo, (PRIVACY_NOTICE) I'll correct that

flawmop commented 1 year ago

If you're changing things, could you also change ap_nimubs to ap_nimbus in ap-nimbus-client too?

MauriceHendrix commented 1 year ago

If you're changing things, could you also change ap_nimubs to ap_nimbus in ap-nimbus-client too?

never noticed that either sorry see PR 95

flawmop commented 1 year ago

I was thinking of merging this PR today. Are you still ok for it to go ahead as I made quite a few more changes since a month ago?