Lower level unit tests for every QC criterion

CardiacModelling / pcpostprocess

BSD 3-Clause "New" or "Revised" License

1 stars 0 forks source link

Lower level unit tests for every QC criterion #21

Open mirams opened 1 month ago

mirams commented 1 month ago

We want an example of a trace to pass/fail each QC criterion, in the automated test suite.

mirams commented 1 month ago

Based on CSV files so they don't depend on other libraries to export code etc.

kwabenantim commented 1 month ago

To Do

[x] Review current tests
- [x] Fix possible bug in trace_after
[ ] Change data input from loading json files to loading pickled Trace objects #25
[x] Double-check ranges/thresholds against paper (https://doi.org/10.1016/j.bpj.2019.07.029)
[x] Output number that failed/passed as well as pass/fail result.
[ ] Add unit testing for each QC.

frankiepe commented 1 month ago

We may need to separate the Trace class from syncropatch_export so we don't rely on syncropatch_export. In the meantime, we will pickle the Trace objects and load them in, but continue to rely on syncropatch_export to manipulate the Trace objects once loaded.