A0-2883: Make keychain synchronous

Cardinal-Cryptography / AlephBFT

Rust implementation of Aleph consensus protocol

https://cardinal-cryptography.github.io/AlephBFT/index.html

Apache License 2.0

56 stars 28 forks source link

A0-2883: Make keychain synchronous #313

Closed woocash2 closed 1 year ago

woocash2 commented 1 year ago

The general change was to make sign(...) in crypto/signature::Keychain synchronous. Removal of 1 async keyword caused all the other changes... The other changes included:

removal of async from other functions
removal of await in function calls which were no longer async
changing #[tokio::test] to #[test] if a test was no longer async
removal of one #[async_trait]
possibly some other minor stuff.

github-actions[bot] commented 1 year ago

Please make sure the following happened

[ ] Appropriate tests created
[ ] Infrastructure updated accordingly
[ ] Updated existing documentation
[ ] New documentation created
[ ] Version bumped if breaking changes