A0-3185: split rmc - Githubissues

Cardinal-Cryptography / AlephBFT

Rust implementation of Aleph consensus protocol

https://cardinal-cryptography.github.io/AlephBFT/index.html

Apache License 2.0

53 stars 28 forks source link

A0-3185: split rmc #347

Closed woocash2 closed 11 months ago

woocash2 commented 1 year ago

Splits the rmc logic into Service of 1 async method and synchronous Handler. The split assures that rmc can be safely initialized from backup state and provides consistency with the design of our other components.

Rewritten unit tests for rmc::Service
Ran blockchain and ordering examples to verify the behavior after the changes

Not tested yet:

Usage with aleph-node
Scenarios with forks which should trigger alerts and thus rmcs

github-actions[bot] commented 1 year ago

Please make sure the following happened

[ ] Appropriate tests created
[ ] Infrastructure updated accordingly
[ ] Updated existing documentation
[ ] New documentation created
[ ] Version bumped if breaking changes