Cardinal-Cryptography / AlephBFT

Rust implementation of Aleph consensus protocol
https://cardinal-cryptography.github.io/AlephBFT/index.html
Apache License 2.0
56 stars 28 forks source link

A0-4006: Unit reconstruction refactor #418

Closed timorleph closed 8 months ago

timorleph commented 8 months ago

Reconstructing the explicit structure of the Dag from the, somewhat compressed, is now handled by a component named "reconstruction" rather than the cryptic "terminal". Internally it also consists of two separate pieces of logic – reconstructing the explicit hashes of parents and ensuring the order of units being added to the Dag.

This leaves a couple awkward points, which will hopefully be ironed out by further refactors around runway.

A big part of the motivation for this refactor is making the upcoming change to differently defined parents simpler to implement.

github-actions[bot] commented 8 months ago

Please make sure the following happened

timorleph commented 8 months ago

Added a small change, since DAG reconstruction does not actually need unit copies, and it likely won't be the component finally holding them; we will see in the next PRs though.