A0-4212: Reconstruct synchronously

Cardinal-Cryptography / AlephBFT

Rust implementation of Aleph consensus protocol

https://cardinal-cryptography.github.io/AlephBFT/index.html

Apache License 2.0

53 stars 28 forks source link

A0-4212: Reconstruct synchronously #431

Closed timorleph closed 5 months ago

timorleph commented 5 months ago

Parent reconstruction now happens synchronously together with validation. This also removes the consensus component, since otherwise it would have just been a thin wrapper around creation. It's likely that runway will eventually be renamed to consensus, but it's not ready yet.

github-actions[bot] commented 5 months ago

Please make sure the following happened

[ ] Appropriate tests created
[ ] Infrastructure updated accordingly
[ ] Updated existing documentation
[ ] New documentation created
[ ] Version bumped if breaking changes

woocash2 commented 5 months ago

Overall looks good, ABFT is really getting simpler and more readable. I found one thing which made me ponder... (my last comment). I'll abstain from accepting the PR for now and wait for the response. Other than that, all clear.