A0-4215: Make extender synchronous

Cardinal-Cryptography / AlephBFT

Rust implementation of Aleph consensus protocol

https://cardinal-cryptography.github.io/AlephBFT/index.html

Apache License 2.0

53 stars 28 forks source link

A0-4215: Make extender synchronous #436

Closed timorleph closed 5 months ago

timorleph commented 5 months ago

One fewer spawn.

github-actions[bot] commented 5 months ago

Please make sure the following happened

[ ] Appropriate tests created
[ ] Infrastructure updated accordingly
[ ] Updated existing documentation
[ ] New documentation created
[ ] Version bumped if breaking changes

woocash2 commented 5 months ago

I'm worried that this refactor may have negative impact on the performance. Extender contains relatively heavy logic and now sending out a unit through the network is delayed by it.

Have you considered changing order of operations in on_unit_backup_saved? I.e. is there a chance that the overall performance will be better if self.ordering.add_unit(unit.clone()) was executed at the end of the function?