search

CardinalPath / gas

Google Analytics on Steroids. A Google Analytics implementation with more power features.
Other
593 stars 78 forks source link

Parse YouTube Video ID from URL #30

Closed dbarlett closed 12 years ago

dbarlett commented 12 years ago

Revised version of Pull Request #29.

eduardocereto commented 12 years ago

We don't really need the id, we can use the full url as a key to the maps. So I managed to simplify it a bit.

The downside is that the old video_id was not the same as the video_id you get from the url, it was really a unique id for any video in the page. So before you could have the same video multiple times on the page and not anymore. I guess it's not a big issue, at least it works now. I merged into the develop branch and I'll merge back into the master branch later this week when I'll probably do a release for v 1.10.

But thanks for looking into this one.