CardinalPath / gas

Google Analytics on Steroids. A Google Analytics implementation with more power features.
Other
593 stars 78 forks source link

Dynamically Added Youtube #47

Closed toddhlynch closed 10 years ago

toddhlynch commented 11 years ago

If you dynamically add youtube iframes with JS, you cannot add re-add the tracker. This fix makes it work:

if (window['onYouTubePlayerAPIReady']) {
  var p;
  for (var i = 0; i < youtube_videos.length; i++) {
    p = new window['YT']['Player'](youtube_videos[i]);
    p.addEventListener('onStateChange', _ytStateChange);
    p.addEventListener('onError', _ytError);
  }
} else {
  window['onYouTubePlayerAPIReady'] = function () {
    var p;
    for (var i = 0; i < youtube_videos.length; i++) {
      p = new window['YT']['Player'](youtube_videos[i]);
      p.addEventListener('onStateChange', _ytStateChange);
      p.addEventListener('onError', _ytError);
    }
  };
}
tomfuertes commented 10 years ago

Thanks! We won't include this in core, but good to know we have the code.