search

CardinalPath / gas

Google Analytics on Steroids. A Google Analytics implementation with more power features.
Other
593 stars 78 forks source link

Added dc.js support through script tag id and data attribute #51

Closed tomfuertes closed 10 years ago

tomfuertes commented 10 years ago

refs pull request #33

LinsBC commented 10 years ago

Is this good to use yet? I have a client using GAS who wishes to integrate DoubleClick so wondering if I can advise him to implement this method?

tomfuertes commented 10 years ago

Should be working. Testing welcome :)

On Wed, Oct 16, 2013 at 7:03 PM, LinsBC notifications@github.com wrote:

Is this good to use yet? I have a client using GAS who wishes to integrate DoubleClick so wondering if I can advise him to implement this method?

— Reply to this email directly or view it on GitHubhttps://github.com/CardinalPath/gas/pull/51#issuecomment-26469811 .

LinsBC commented 10 years ago

Thanks Tom,

Should I be warning the client that this is in beta? And if so, any ideas when it might be migrated to the main version?

BrianKatz commented 10 years ago

Do you believe there is a likelihood of dc.js from being blocked and to have a fallback to ga.js?

Brian Katz

Sr. Web Analyst, CWA Vancouver, British Columbia (Pacific Time) phone +1 778.374.3004 x224 web CardinalPath.com On 2013-10-16 9:03 PM, "LinsBC" notifications@github.com wrote:

Thanks Tom,

So can I confirm that I need my client to implement the following code:

Should I be warning the client that this is in beta?

— Reply to this email directly or view it on GitHubhttps://github.com/CardinalPath/gas/pull/51#issuecomment-26477894 .

Connect with us on twitter http://twitter.com/cardinalpath, google+https://plus.google.com/108076800625872227241/posts , facebook http://www.facebook.com/CardinalPath, or linkedinhttp://www.linkedin.com/company/cardinal-path .

Catch our next training in New York City Oct 14 - 18http://training.cardinalpath.com/google-adwords-analytics/new-york-city/?utm_campaign=cp-cpt&utm_source=sig-referral&utm_medium=email&utm_content=newyorkcity-2013-10-14#2013-10-14 , Berkely Oct 21 - 25http://training.cardinalpath.com/google-adwords-analytics/berkeley/?utm_campaign=cp-cpt&utm_source=sig-referral&utm_medium=email&utm_content=berkeley-2013-10-21 , Boston Oct 28 - Nov 1http://training.cardinalpath.com/google-adwords-analytics/seattle/?utm_campaign=cp-cpt&utm_source=sig-referral&utm_medium=email&utm_content=boston-2013-11-04 , http://training.cardinalpath.com/google-adwords-analytics/phoenix/?utm_campaign=cp-cpt&utm_source=sig-referral&utm_medium=email&utm_content=phoenix-2013-11-11Phoenix Nov 11 - 15http://training.cardinalpath.com/google-adwords-analytics/phoenix/?utm_campaign=cp-cpt&utm_source=sig-referral&utm_medium=email&utm_content=phoenix-2013-11-11 or See Allhttp://training.cardinalpath.com/locations/?utm_campaign=cp-s4s&utm_source=cp-email-footer&utm_medium=email&utm_content=see-all .

This email, including any attachments, is for the sole use of the intended recipient and may contain confidential information. If you are not the intended recipient, please immediately notify us by reply email or by telephone, delete this email and destroy any copies. Thank you

tomfuertes commented 10 years ago

@LinsBC -- test it somewhere first w/ the Google Analytics Debugger (Chrome) and if pageviews fire it should be fine to be "out of beta"

@BrianKatz -- I coded a shim like this before at my past employ (30M visits / day between properties). We saw less than a 0.25% drop now that adblock whitelisted the dc.js file. The fallback seemed a bit overkill for it and sometimes double loaded / generated false positives. Would not recommend it for effort/priority.

DarrenCarterMD commented 10 years ago

Thanks for this! I'm excited to start using the new version, but I'm afraid I'm not familiar enough with how github works to download new version. I checked the download and releases page, and the latest version 1.11.0 isn't listed.

https://github.com/CardinalPath/gas/downloads https://github.com/CardinalPath/gas/releases

Will something be uploaded there, or do I need to do something in github to create the file(s)?

Sorry I'm such a noob!

tomfuertes commented 10 years ago

No worries! I'm not sponsored on this project, but will upload a release candidate type package somewhere shortly and send you a link!

-Tom (via phone)

On Fri, Oct 18, 2013 at 10:08 AM, Darren Carter, MD notifications@github.com wrote:

Thanks for this! I'm excited to start using the new version, but I'm afraid I'm not familiar enough with how github works to download new version. I checked the download and releases page, and the latest version 1.11.0 isn't listed. https://github.com/CardinalPath/gas/downloads https://github.com/CardinalPath/gas/releases Will something be uploaded there, or do I need to do something in github to create the file(s)?

Sorry I'm such a noob!

Reply to this email directly or view it on GitHub: https://github.com/CardinalPath/gas/pull/51#issuecomment-26603223

BrianKatz commented 10 years ago

Thanks Tom

Brian Katz

Sr. Web Analyst, CWA Vancouver, British Columbia (Pacific Time) phone +1 778.374.3004 x224 web CardinalPath.com On 2013-10-18 8:13 AM, "Tom Fuertes" notifications@github.com wrote:

No worries! I'm not sponsored on this project, but will upload a release candidate type package somewhere shortly and send you a link!

-Tom (via phone)

On Fri, Oct 18, 2013 at 10:08 AM, Darren Carter, MD notifications@github.com wrote:

Thanks for this! I'm excited to start using the new version, but I'm afraid I'm not familiar enough with how github works to download new version. I checked the download and releases page, and the latest version 1.11.0 isn't listed. https://github.com/CardinalPath/gas/downloads https://github.com/CardinalPath/gas/releases Will something be uploaded there, or do I need to do something in github to create the file(s)?

Sorry I'm such a noob!

Reply to this email directly or view it on GitHub: https://github.com/CardinalPath/gas/pull/51#issuecomment-26603223

— Reply to this email directly or view it on GitHubhttps://github.com/CardinalPath/gas/pull/51#issuecomment-26603688 .

Connect with us on twitter http://twitter.com/cardinalpath, google+https://plus.google.com/108076800625872227241/posts , facebook http://www.facebook.com/CardinalPath, or linkedinhttp://www.linkedin.com/company/cardinal-path .

Catch our next training in New York City Oct 14 - 18http://training.cardinalpath.com/google-adwords-analytics/new-york-city/?utm_campaign=cp-cpt&utm_source=sig-referral&utm_medium=email&utm_content=newyorkcity-2013-10-14#2013-10-14 , Berkeley Oct 21 - 25http://training.cardinalpath.com/google-adwords-analytics/berkeley/?utm_campaign=cp-cpt&utm_source=sig-referral&utm_medium=email&utm_content=berkeley-2013-10-21 , Boston Oct 28 - Nov 1http://training.cardinalpath.com/google-adwords-analytics/seattle/?utm_campaign=cp-cpt&utm_source=sig-referral&utm_medium=email&utm_content=boston-2013-11-04 , http://training.cardinalpath.com/google-adwords-analytics/phoenix/?utm_campaign=cp-cpt&utm_source=sig-referral&utm_medium=email&utm_content=phoenix-2013-11-11Phoenix Nov 11 - 15http://training.cardinalpath.com/google-adwords-analytics/phoenix/?utm_campaign=cp-cpt&utm_source=sig-referral&utm_medium=email&utm_content=phoenix-2013-11-11 or See Allhttp://training.cardinalpath.com/locations/?utm_campaign=cp-s4s&utm_source=cp-email-footer&utm_medium=email&utm_content=see-all .

This email, including any attachments, is for the sole use of the intended recipient and may contain confidential information. If you are not the intended recipient, please immediately notify us by reply email or by telephone, delete this email and destroy any copies. Thank you

DarrenCarterMD commented 10 years ago

Much thanks, Tom!

Darren Carter Principal

NYC SEM http://www.nycsem.com 130 Bradhurst Avenue Unit 105 http://maps.google.com/maps?q=130+Bradhurst+Avenue+%2CUnit+105%2CNew+York%2CNY+10039%2CUSA&hl=enNew York, NY 10039 USA Work:\ (646) 450-3631 Mobile: (917) 545-2435 Email: darren@nycsem.com IM: nycsem (Skype) http://www.nycsem.com http://www.linkedin.com/in/darrencartermd See who we know in commonhttp://www.linkedin.com/e/wwk/5819153/?hs=false&tok=2wqs7eQPiQARI1

On Fri, Oct 18, 2013 at 11:13 AM, Tom Fuertes notifications@github.comwrote:

No worries! I'm not sponsored on this project, but will upload a release candidate type package somewhere shortly and send you a link!

-Tom (via phone)

On Fri, Oct 18, 2013 at 10:08 AM, Darren Carter, MD notifications@github.com wrote:

Thanks for this! I'm excited to start using the new version, but I'm afraid I'm not familiar enough with how github works to download new version. I checked the download and releases page, and the latest version 1.11.0 isn't listed. https://github.com/CardinalPath/gas/downloads https://github.com/CardinalPath/gas/releases Will something be uploaded there, or do I need to do something in github to create the file(s)?

Sorry I'm such a noob!

Reply to this email directly or view it on GitHub: https://github.com/CardinalPath/gas/pull/51#issuecomment-26603223

— Reply to this email directly or view it on GitHubhttps://github.com/CardinalPath/gas/pull/51#issuecomment-26603688 .

tomfuertes commented 10 years ago

Tested locally and confirmed it's loading dc.js! You can download the release candidate zip at this link: https://dl.dropboxusercontent.com/u/7795606/gas-1.11.0.rc2.zip

The new snippet for how to load it can be found here: https://gist.github.com/tomfuertes/7043966

For now you'll have to host your own gas.min.js somewhere until the pull request is merged and 1.11.0 is shipped to the CDN.

tomfuertes commented 10 years ago

Ping @DarrenCarterMD and @LinsBC -- release candidate script is zipped and linked to in the comment above

LinsBC commented 10 years ago

Thanks Tom. That's very helpful and much appreciated.

DarrenCarterMD commented 10 years ago

Hi, Tom,

I downloaded and unzipped the files, but when I opened it in my editor TextPad or even Notepad, it said that some characters didn't exist in ANSI and would convert them. This is apparently breaking the script for me. I've installed the new script and snippet at this site:

zokydoky.com

However, Analytics tracking stopped. When I looked at the local script, gas.min.js, some areas looked suspect like the following

{if(!this.tracker){var b=a._gat._getTrackers();b.length>0&&(this.tracker=b[0])}},E.prototype.inArray=function(a,b){if(a&&a.length)for(var c=0;c<a.length;c++)if(a[c]===b)return!0;return!1},E.prototype.sanitizeString=function(a,b){return a=a.toLowerCase().replace(/^\ +/,"").replace(/\ +$/,"").replace(/\s+/g,"").replace(/[áà âãåäæª]/g,"a").replace(/[éèêëЄ€]/g,"e").replace(/[íìîï]/g,"i").replace(/[óòôõöøº]/g,"o").replace(/[úùûü]/g,"u").replace(/[碩]/g,"c"),b&&(a=a.replace(/[^a-z0-9-]/g,"")),a.replace(/+/g,"")},E.prototype._addEventListener=function(b,c,d,e){var f=function(c){return c&&c.target||(c=a.event,c.target=c.srcElement),d.call(b,c)};return b.addEventListener?

How do I fix this?

Darren Carter Principal

NYC SEM http://www.nycsem.com 130 Bradhurst Avenue Unit 105 http://maps.google.com/maps?q=130+Bradhurst+Avenue+%2CUnit+105%2CNew+York%2CNY+10039%2CUSA&hl=enNew York, NY 10039 USA Work:\ (646) 450-3631 Mobile: (917) 545-2435 Email: darren@nycsem.com IM: nycsem (Skype) http://www.nycsem.com http://www.linkedin.com/in/darrencartermd See who we know in commonhttp://www.linkedin.com/e/wwk/5819153/?hs=false&tok=2wqs7eQPiQARI1

On Fri, Oct 18, 2013 at 12:25 PM, Tom Fuertes notifications@github.comwrote:

Tested locally and confirmed it's loading dc.js! You can download the release candidate zip at this link: https://dl.dropboxusercontent.com/u/7795606/gas-1.11.0.rc1.zip

The new snippet for how to load it can be found here: https://gist.github.com/tomfuertes/7043966

For now you'll have to host your own gas.min.js somewhere until the pull request is merged and 1.11.0 is shipped to the CDN.

— Reply to this email directly or view it on GitHubhttps://github.com/CardinalPath/gas/pull/51#issuecomment-26609597 .

tomfuertes commented 10 years ago

O.o Thanks and apologies! The new build system doesn't handle ascii/unicode in the same way. I deprecated/removed the offending function/code. You can download the patched release candidate below:

https://dl.dropboxusercontent.com/u/7795606/gas-1.11.0.rc2.zip

-- ping @LinsBC per the @DarrenCarterMD bug report above.

DarrenCarterMD commented 10 years ago

Thanks for all your help, Tom!

I tried the download link, and it goes to a 404 page. Can you double-check?

On Wed, Oct 23, 2013 at 10:21 AM, Tom Fuertes notifications@github.comwrote:

O.o Thanks and apologies! The new build system doesn't handle ascii/unicode in the same way. I deprecated/removed the offending function/code. You can download the patched release candidate is below:

https://dl.dropboxusercontent.com/u/7795606/gas-1.11.0.rc1.zip

-- ping @LinsBC https://github.com/LinsBC per the @DarrenCarterMDhttps://github.com/DarrenCarterMDbug report above.

— Reply to this email directly or view it on GitHubhttps://github.com/CardinalPath/gas/pull/51#issuecomment-26908738 .

tomfuertes commented 10 years ago

@DarrenCarterMD Sorry I pasted the old link in the original comment and edited it soon thereafter, but apparently not before the notification emails went out!

Try this one: https://dl.dropboxusercontent.com/u/7795606/gas-1.11.0.rc2.zip

One more time for @LinsBC

LinsBC commented 10 years ago

Thanks all. This is timely as I am sending the code to a client later today. I would appreciate any feedback if any of you get it working or have issues so that I can ensure I am sending the right thing to the client.

On Thursday, 24 October 2013, Tom Fuertes wrote:

@DarrenCarterMD https://github.com/DarrenCarterMD Sorry I pasted the old link in the original comment and edited it soon thereafter, but apparently not before the notification emails went out!

Try this one: https://dl.dropboxusercontent.com/u/7795606/gas-1.11.0.rc2.zip

One more time for @LinsBC https://github.com/LinsBC

— Reply to this email directly or view it on GitHubhttps://github.com/CardinalPath/gas/pull/51#issuecomment-26911954 .

Lindsey Buckle

Mob: +61 (0) 415 658428 Web: http://www.lindseybuckle.com

http://linsinproduction.blogspot.com http://linsdownunder.blogspot.com

DarrenCarterMD commented 10 years ago

Hi,

I've tried the new script on a few sites, and I'm having mixed success. Would you mind having a look to see if I am missing anything?

On these two sites, it's not working. http://protectsmart.net http://zokydoky.com

Both have the same errors from the Google Tag Manager extension in Chrome: From Google Tag Manager: Error: No HTTP response detected more infohttp://support.google.com/analytics/bin/answer.py?answer=1008080#http_response Error: Missing ga.js script more info http://support.google.com/analytics/bin/answer.py?answer=1008083

On this site, the tag is working. There are a couple differences in implementation: 1) the script is in the body and not the head. 2) I also am using a hosted version of the script and don't have it locally. Could that be it? http://www.melroseorthodontics.com

Much thanks!

Darren Carter Principal

NYC SEM http://www.nycsem.com 130 Bradhurst Avenue Unit 105 http://maps.google.com/maps?q=130+Bradhurst+Avenue+%2CUnit+105%2CNew+York%2CNY+10039%2CUSA&hl=enNew York, NY 10039 USA Work:\ (646) 450-3631 Mobile: (917) 545-2435 Email: darren@nycsem.com IM: nycsem (Skype) http://www.nycsem.com http://www.linkedin.com/in/darrencartermd See who we know in commonhttp://www.linkedin.com/e/wwk/5819153/?hs=false&tok=2wqs7eQPiQARI1

On Wed, Oct 23, 2013 at 4:49 PM, LinsBC notifications@github.com wrote:

Thanks all. This is timely as I am sending the code to a client later today. I would appreciate any feedback if any of you get it working or have issues so that I can ensure I am sending the right thing to the client.

On Thursday, 24 October 2013, Tom Fuertes wrote:

@DarrenCarterMD https://github.com/DarrenCarterMD Sorry I pasted the old link in the original comment and edited it soon thereafter, but apparently not before the notification emails went out!

Try this one: https://dl.dropboxusercontent.com/u/7795606/gas-1.11.0.rc2.zip

One more time for @LinsBC https://github.com/LinsBC

— Reply to this email directly or view it on GitHub< https://github.com/CardinalPath/gas/pull/51#issuecomment-26911954> .

Lindsey Buckle

Mob: +61 (0) 415 658428 Web: http://www.lindseybuckle.com

http://linsinproduction.blogspot.com http://linsdownunder.blogspot.com

— Reply to this email directly or view it on GitHubhttps://github.com/CardinalPath/gas/pull/51#issuecomment-26944256 .

tomfuertes commented 10 years ago

@DarrenCarterMD Sure, which urls?

DarrenCarterMD commented 10 years ago

On these two sites, it's not working. http://protectsmart.net http://zokydoky.com

Both have the same errors from the Google Tag Manager extension in Chrome: From Google Tag Manager: Error: No HTTP response detected Error: Missing ga.js script

On this site, the tag is working. http://www.melroseorthodontics.com

There are a couple differences in implementation: 1) the script is in the body and not the head. 2) I also am using a hosted version of the script and don't have it locally. Could either be part of it?

Much thanks!

tomfuertes commented 10 years ago

The first two urls don't actually reference an online script.

Change all of your current src's from ga.src = '//demo/js/gas.min.js'; to ga.src = '//s3.amazonaws.com/nycsem/gas.min.js'; like it is on the working site.

The universal analytics implementation on the first one is also missing a closing tag

DarrenCarterMD commented 10 years ago

But the current src's do point to a local instance of the gas.min.js script. For example, http://protectsmart.net/demo/js/gas.min.js is present. Why doesn't the local implementation work?

Thanks for the catching the universal tracking tag issue!

tomfuertes commented 10 years ago
DarrenCarterMD commented 10 years ago

That solves it all. I'll go with my hosted file.

Thanks, again!

philippschneider commented 10 years ago

will the 1.11.0 gas.min.js will be brought to the CDN? Will there be any changes in the documentation?

I can see no chnages on the main page since 1 year...

tomfuertes commented 10 years ago

Working on this today! Have a PR with CDNJS (cdnjs/cdnjs#2207) to get 1.11.0 out on the CDN. I'll publish the 1.11.0 tag to master once that PR goes live.

Changelog Preview of 1.11.0 can be found here and/or read below: https://github.com/CardinalPath/gas/blob/17108967a02fc673ac1b27e15c370ee4b58fe122/CHANGELOG.md

1.11.0

cc @philippschneider

tomfuertes commented 10 years ago

1.11.0 has landed! Pull request rebased and merged into develop/master

If you want to install/update, instructions can be found on the front page README

https://github.com/CardinalPath/gas