Closed reneefromhold closed 1 week ago
[!CAUTION]
Review failed
The pull request is closed.
The changes in this pull request involve updates to multiple Storybook stories and component files across various views. Key modifications include restructuring story exports to utilize a meta
object, introducing a render
function for consistent layout presentation, and adding JSDoc comments for improved documentation. Function signatures have been explicitly named for clarity. The internal logic of the components remains unchanged, ensuring that their functionality is preserved while enhancing the organization and clarity of the codebase.
File Path | Change Summary |
---|---|
src/components/view/ConnectEhrView/ConnectEhrView.stories.tsx |
Updated imports, restructured default export to a meta object, added type declarations, refactored story templates to use a render function, and updated story exports. |
src/components/view/ConnectEhrView/ConnectEhrView.tsx |
Changed function signature to a named export and added JSDoc comment. |
src/components/view/DeviceDataView/DeviceDataView.stories.tsx |
Updated imports, restructured default export to a meta object, added type declarations, replaced Template function with a render function, and updated story exports. |
src/components/view/DeviceDataView/DeviceDataView.tsx |
Changed function signature to a named export and added JSDoc comment. |
src/components/view/EhrNewsFeedView/EhrNewsFeedView.tsx |
Changed function signature to a named export and added JSDoc comment. |
src/components/view/ExternalAccountsView/ExternalAccountsView.stories.tsx |
Updated imports, restructured default export to a meta object, added type declarations, replaced Template function with a render function, and updated story exports. |
src/components/view/ExternalAccountsView/ExternalAccountsView.tsx |
Changed function signature to a named export and added JSDoc comment. |
src/components/view/FitbitView/FitbitView.stories.tsx |
Updated imports, restructured default export to a meta object, added type declarations, replaced Template function with a render function, and updated story exports. |
src/components/view/FitbitView/FitbitView.tsx |
Changed function signature to a named export and added JSDoc comment. |
src/components/view/GarminView/GarminView.stories.tsx |
Updated imports, restructured default export to a meta object, added type declarations, replaced Template function with a render function, and updated story exports. |
src/components/view/GarminView/GarminView.tsx |
Changed function signature to a named export and added JSDoc comment. |
src/components/view/HealthAndWellnessView/HealthAndWellnessView.stories.tsx |
Updated imports, restructured default export to a meta object, added type declarations, replaced Template function with a render function, and updated story exports. |
src/components/view/HealthAndWellnessView/HealthAndWellnessView.tsx |
Changed function signature to a named export and added JSDoc comment. |
src/components/view/HomeView/HomeView.stories.tsx |
Updated imports, restructured default export to a meta object, added type declarations, replaced Template function with a render function, and updated story exports. |
src/components/view/HomeView/HomeView.tsx |
Changed function signature to a named export and added JSDoc comment. |
src/components/view/NotificationsView/NotificationsView.stories.tsx |
Updated imports, restructured default export to a meta object, added type declarations, replaced Template function with a render function, and added new story exports. |
src/components/view/NotificationsView/NotificationsView.tsx |
Changed function signature to a named export and added JSDoc comment. |
src/components/view/SurveyTasksView/SurveyTasksView.stories.tsx |
Updated imports, restructured default export to a meta object, added type declarations, replaced Template function with a render function, and updated story exports. |
src/components/view/SurveyTasksView/SurveyTasksView.tsx |
Changed function signature to a named export and added JSDoc comment. |
src/components/view/AllergiesView/AllergiesView.tsx |
Changed function signature to a named export and added JSDoc comment. |
src/components/view/NewPointsView/NewPointsView.tsx |
Changed function signature to a named export, added JSDoc comment, and made minor formatting changes. |
tsconfig.json |
Added compiler options and an include section to specify files for compilation. |
src/components/step/StepNextButton/StepNextButton.stories.tsx |
Updated imports, restructured default export to a meta object, added type declarations, replaced Template function with a render function, and updated story exports. |
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Overview
Running npm run rollup locally results in a lot of noise/warnings that make it more time consuming to determine if a change has broken the build.
This is the first step at cutting back the noise starting with out of the box views.
A description for the view was added as part of the update. This description will show as part of the component's default story.
Security
REMINDER: All file contents are public.
Describe briefly what security risks you considered, why they don't apply, or how they've been mitigated.
Checklist
Testing
Documentation
Consider "Squash and merge" as needed to keep the commit history reasonable on
main
.Reviewers
Assign to the appropriate reviewer(s). Minimally, a second set of eyes is needed ensure no non-public information is published. Consider also including:
Summary by CodeRabbit
New Features
ConnectEhrView
,DeviceDataView
,ExternalAccountsView
,FitbitView
,GarminView
,HealthAndWellnessView
,HomeView
,NotificationsView
, andSurveyTasksView
components with improved organization and documentation.Disabled
story for theStepNextButton
component.Documentation
Refactor
Template
functions torender
functions in Storybook stories for better structure.Chores
tsconfig.json
to include additional compiler options and specify files for compilation.